Skip to content

Address PR #75 review feedback: env var support, priority names, and whitespace #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-dickey merged 4 commits into from
Feb 12, 2026
Merged

Address PR #75 review feedback: env var support, priority names, and whitespace #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e55294e
Initial plan
Copilot Feb 12, 2026
5568561
Address PR review feedback: fix env var, priority names, and whitespace
Copilot Feb 12, 2026
b1f72bf
Improve tracking file with clear note about missing P0-3 issue
Copilot Feb 12, 2026
fdac3c5
Handle empty/whitespace GITHUB_REPOSITORY env var
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions _bmad-output/implementation-artifacts/code-review-issues-tracking.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ Source: Code Review 2026-02-02

## Created Issues

### P0 (unknown)
**Note**: P0-3 (Implement WebSocket Infrastructure for Real-Time Features) from the source JSON was not created as a GitHub issue during the initial creation run. This may have been intentional or an oversight during the creation process.

### P0 (Critical)

- [ ] #61 - [P0] Consolidate CI/CD Workflows to Eliminate Duplicate Test Runs
- [ ] #62 - [P0] Implement Organization Scoping Middleware for Multi-Tenancy
- [ ] #63 - [P0] Fix Test Database Configuration (PostgreSQL in CI)
- [ ] #64 - [P0] Document Required GitHub Secrets for CI/CD

### P1 (unknown)
### P1 (High)

- [ ] #65 - [P1] Update Outdated Dependencies with Security Patches
- [ ] #66 - [P1] Add Frontend CI Workflow for Quality Validation
Expand Down
4 changes: 2 additions & 2 deletions backend/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ redis==5.0.1 #Ensure actual Redis server version (container or cloud) is reasona

# Validation & Settings
pydantic==2.12.5 # Track FastAPI reasonably closely; upgrade Pydantic within the same major version when needed, not arbitrarily
pydantic-settings==2.1.0
email-validator==2.1.0
pydantic-settings==2.1.0
email-validator==2.1.0

# Testing
pytest==9.0.2
Expand Down
3 changes: 2 additions & 1 deletion scripts/create-github-issues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@
"""

import json
import os
import subprocess
import sys
import time
from pathlib import Path
from typing import List, Dict, Tuple, Optional

REPO = "tim-dickey/trivia-app"
REPO = (os.environ.get("GITHUB_REPOSITORY") or "").strip() or "tim-dickey/trivia-app"
SCRIPT_DIR = Path(__file__).parent
ISSUES_DIR = SCRIPT_DIR.parent / "_bmad-output/implementation-artifacts"

Expand Down