Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容(箇条書き)
『素晴らしいプロダクトに感謝しています。』
READMEの使い方のコードに以下を追記するのはいかがでしょうか?
使い方のソースコードに
require
の記述を含めた方がユーザーが問題なくfaker-japanese
を使用できるかもしれないと思ったため。gem install faker-japanese
を実行後、初学者はどのようにrequire
したらいいのかわからない可能性があるため。私自身、
require faker-japanese
と記述してしまいloadエラーを起こしてしまったため。また、今後の実装次第だとは思われますが、
require "faker/japanese/name"
などの方法でfaker-japaneseの部分的な利用が可能だということもREADMEに記述されるのはいかがでしょうか?
環境
OS: mac OS Monterey 12.6.5
Ruby:3.2.2