Skip to content

restart_process: Add image_deps & platform to custom_build_with_restart #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

restart_process: Add image_deps & platform to custom_build_with_restart #644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c411c8
restart_process: Add image_deps and platform to custom_build_with_res…
glennpratt Sep 10, 2025
5ae0994
lint fix
glennpratt Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions restart_process/Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ _CUSTOM_BUILD_KWARGS_BLACKLIST = [
'disable_push',
'dir',
'env',
'image_deps',
]

_ext_dir = os.getcwd()
Expand Down Expand Up @@ -109,7 +110,7 @@ def docker_build_with_restart(ref, context, entrypoint, live_update,

def custom_build_with_restart(ref, command, deps, entrypoint, live_update,
base_suffix='-tilt_docker_build_with_restart_base', restart_file=RESTART_FILE,
trigger=None, exit_policy='restart', **kwargs):
trigger=None, exit_policy='restart', platform=None, **kwargs):
"""Wrap a custom_build call and its associated live_update steps so that the last step
of any live update is to rerun the given entrypoint.

Expand All @@ -123,6 +124,7 @@ def custom_build_with_restart(ref, command, deps, entrypoint, live_update,
restart_file: file that Tilt will update during a live_update to signal the entrypoint to rerun
trigger: (optional) list of local paths. If specified, the process will ONLY be restarted when there are changes
to the given file(s); as the parameter of the same name in the LiveUpdate `run` step.
platform: (optional) will be passed to the underlying `docker_build` (e.g. 'linux/amd64'). `command` must still specify platform itself.
**kwargs: will be passed to the underlying `custom_build` call
"""

Expand All @@ -144,7 +146,10 @@ def custom_build_with_restart(ref, command, deps, entrypoint, live_update,

# rename the original image to make it a base image and declare a custom_build for it
base_ref = '{}{}'.format(ref, base_suffix)
custom_build(base_ref, command=command, deps=deps, **kwargs)

# Create kwargs for custom_build (remove platform since custom_build handles multiplatform in its script)
custom_build_kwargs = {k: v for k, v in kwargs.items() if k != 'platform'}
Copy link
Member

@nicks nicks Sep 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... this PR -

  • add platform as an explicit arg, which removes it from kwargs
  • also adds a few lines that clean platform from kwargs

that doesn't really make sense? you'd want to do one or the other, but not both?

(i think you meant to only do the second one)

custom_build(base_ref, command=command, deps=deps, **custom_build_kwargs)

# A few arguments aren't applicable to the docker_build, so remove them.
cleaned_kwargs = {k: v for k, v in kwargs.items() if k not in _CUSTOM_BUILD_KWARGS_BLACKLIST}
Expand Down