Skip to content

[Vulkan] Backport SPIR-V fixes from apache/tvm main #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kabu1204 wants to merge 2 commits into
base: tilelang_main
Choose a base branch
from
Open

[Vulkan] Backport SPIR-V fixes from apache/tvm main #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18166b
[SPIRV] Fix forloop codegen in vulkan (#18715)
tqchen Feb 5, 2026
189b59a
[Vulkan] Avoid explicit layout decoration on non-interface allocation…
kabu1204 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/target/spirv/codegen_spirv.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,13 +676,12 @@ void CodeGenSPIRV::VisitStmt_(const ForNode* op) {
spirv::Value init_value = MakeValue(op->min);
PrimExpr end = is_zero(op->min) ? op->extent : analyzer_->Simplify(op->min + op->extent);
spirv::Value end_value = MakeValue(end);
spirv::PhiValue loop_var = builder_->MakePhi(init_value.stype, 2);

// loop step
spirv::Value step;
if (op->HasTrivialStep()) {
step = op->loop_var.dtype().is_int() ? builder_->IntImm(loop_var.stype, 1)
: builder_->UIntImm(loop_var.stype, 1);
step = op->loop_var.dtype().is_int() ? builder_->IntImm(init_value.stype, 1)
: builder_->UIntImm(init_value.stype, 1);
} else {
step = MakeValue(tvm::cast(end->dtype, *op->step));
}
Expand All @@ -699,8 +698,9 @@ void CodeGenSPIRV::VisitStmt_(const ForNode* op) {
builder_->SetName(merge_label, "for_loop_merge");
builder_->MakeInst(spv::OpBranch, head_label);

// Loop head
// Loop head - Phi must be created AFTER StartLabel so it's in the head block
builder_->StartLabel(head_label);
spirv::PhiValue loop_var = builder_->MakePhi(init_value.stype, 2);
loop_var.SetIncoming(0, init_value, init_label);
spirv::Value loop_cond = builder_->LT(loop_var, end_value);
uint32_t control =
Expand Down
Loading