Skip to content

[Build] Fix cross platform CMake and add messages when enabling backends#2183

Merged
SiriusNEO merged 1 commit into
tile-ai:mainfrom
SiriusNEO:chaofan/backend_0507
May 11, 2026
Merged

[Build] Fix cross platform CMake and add messages when enabling backends#2183
SiriusNEO merged 1 commit into
tile-ai:mainfrom
SiriusNEO:chaofan/backend_0507

Conversation

@SiriusNEO
Copy link
Copy Markdown
Collaborator

@SiriusNEO SiriusNEO commented May 11, 2026

Address some issues in thread: #2114

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced build-time diagnostics with status messages for active backend configurations (CUDA, Metal, ROCm)
    • Improved backend dependency linking to better preserve existing library references

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b5b4055-f1e0-4700-9a15-925ecfdbc9eb

📥 Commits

Reviewing files that changed from the base of the PR and between beef5cf and 8bc7b3a.

📒 Files selected for processing (3)
  • src/backend/cuda/CMakeLists.txt
  • src/backend/metal/CMakeLists.txt
  • src/backend/rocm/CMakeLists.txt

📝 Walkthrough

Walkthrough

Backend CMake configurations across CUDA, Metal, and ROCm are updated to emit build-time status messages indicating backend enablement. Additionally, CUDA and ROCm stub library registration transitions from overwriting to appending list entries, preserving prior stub configurations.

Changes

Backend CMake Configuration

Layer / File(s) Summary
Backend Enablement Status Logging
src/backend/cuda/CMakeLists.txt, src/backend/metal/CMakeLists.txt, src/backend/rocm/CMakeLists.txt
Status messages added to CUDA, Metal, and ROCm CMake configurations to log when each backend is enabled during build configuration.
Stub Library Registration to Append
src/backend/cuda/CMakeLists.txt, src/backend/rocm/CMakeLists.txt
Stub library registration for CUDA (cuda_stub, cudart_stub, nvrtc_stub) and ROCm (hip_stub, hiprtc_stub) changed from overwriting TILELANG_ACTIVE_BACKEND_STUB_LINK and TILELANG_ACTIVE_BACKEND_STUB_TARGETS lists to appending, preserving existing entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • tile-ai/tilelang#2114: Introduces the same backend stub-linking variables and logic that this PR refines through list append operations.
  • tile-ai/tilelang#2164: Also modifies CUDA/ROCm backend CMakeLists for stub handling and source path registration.
  • tile-ai/tilelang#1821: Introduces CUDA/HIP/ROCm stub registration logic that this PR adapts by switching to list append.

Poem

🐰 A rabbit hops through CMake lands,
Adding logs where backends stand,
No more overwrites, just appends please—
Building stubs with greater ease!
Three backends bright, now logging true.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding backend enable messages and fixing CMake list append logic for cross-platform compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@SiriusNEO SiriusNEO merged commit ed73ab6 into tile-ai:main May 11, 2026
7 of 8 checks passed
Calaweh pushed a commit to Calaweh/tilelang that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant