[MetaxGPU][testing] correct FP64 MMA store layout to fix the test pre…#102
[MetaxGPU][testing] correct FP64 MMA store layout to fix the test pre…#102xxxzh99 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds float64 support to MACA tensor core MMA infrastructure by introducing a float64-aware store index mapping utility, updating both dense and sparse MMA macro generators to handle 64-bit types through dtype abbreviations and k_dim computation, and extending C++ codegen to rewrite float64x4 intrinsics. ChangesFloat64 Support in MACA Tensor Cores
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
fcfa1f8 to
b746f0b
Compare
b746f0b to
1ac49e8
Compare
The corresponding fp64 types have been added to the macro files, and the appropriate fp64 store calculation logic has been added to the utils file.
Summary by CodeRabbit
New Features
Bug Fixes