Skip to content

字符无法匹配cann版本时,使用8.5.0#860

Open
buaazhangs wants to merge 2 commits intotile-ai:npuir-mixfrom
buaazhangs:0481mix
Open

字符无法匹配cann版本时,使用8.5.0#860
buaazhangs wants to merge 2 commits intotile-ai:npuir-mixfrom
buaazhangs:0481mix

Conversation

@buaazhangs
Copy link
Copy Markdown

字符无法匹配cann版本时,使用8.5.0

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the CANN version handling in install_npuir.sh and tilelang/utils/npu_utils.py to default to version '8.5.0' rather than erroring out when versions are unrecognized or environment variables are unset. Feedback includes suggestions to add warning messages when falling back to the default version to improve observability and to update Python type hints to support optional string inputs.

Comment thread install_npuir.sh
Comment thread tilelang/utils/npu_utils.py Outdated
Comment thread tilelang/utils/npu_utils.py
Copy link
Copy Markdown
Collaborator

@CeleNewYear CeleNewYear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happyhappyhappy-arch
Copy link
Copy Markdown
Collaborator

Support for 9.0.0 was merged unintentionally and is recommended to be directly revert commit 9f5ee68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants