[AscendNPU-IR][CI] Hotfix: increase testing/npuir pytest f16 tolerance to 1e-2#847
[AscendNPU-IR][CI] Hotfix: increase testing/npuir pytest f16 tolerance to 1e-2#847mmyy1217 wants to merge 2 commits intotile-ai:npuirfrom
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
There was a problem hiding this comment.
Code Review
This pull request increases the global default tolerance for float16 comparisons from 1e-3 to 1e-2 in the test common utilities. Feedback suggests that this relaxation is too significant and could mask numerical regressions across the entire test suite; it is recommended to override tolerances for specific unstable test cases instead of modifying the global default.
|
|
||
| DEFAULT_TOLERANCE = { | ||
| "float16": (1e-3, 1e-3), | ||
| "float16": (1e-2, 1e-2), |
There was a problem hiding this comment.
Increasing the global float16 tolerance to 1e-2 is a significant relaxation that could mask numerical regressions across the entire test suite. float16 typically supports a precision around 1e-3. A better approach to handle CI failures is to override the tolerance in specific test cases that exhibit instability on the NPU, rather than globally reducing the sensitivity of all tests.
No description provided.