build: fix rebuild rules for no prebuilt bindings #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranrund
force-pushed
the
eranrund/fix-449
branch
from
314b279 to
9b82bf7
Compare
BusyJay
reviewed
Mar 26, 2020
grpc-sys/build.rs
Outdated
| match target.as_str() { | ||
| "x86_64-unknown-linux-gnu" | "aarch64-unknown-linux-gnu" => { | ||
| file_path = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap()) | ||
| .join("bindings") | ||
| .join(format!("{}-bindings.rs", &target)); | ||
| println!( |
There was a problem hiding this comment.
How about add a comment so that future refactor will not break it again?
BusyJay
reviewed
Mar 26, 2020
grpc-sys/build.rs
Outdated
| match target.as_str() { | ||
| "x86_64-unknown-linux-gnu" | "aarch64-unknown-linux-gnu" => { | ||
| file_path = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap()) | ||
| .join("bindings") | ||
| .join(format!("{}-bindings.rs", &target)); | ||
| println!( | ||
| "cargo:rerun-if-changed=bindings/{}", | ||
| file_path.as_path().as_os_str().to_str().unwrap() |
There was a problem hiding this comment.
I suggest to use relative path. Otherwise sharing building cache can become a problem.
|
@BusyJay made the changes, please take another look when you can. Thanks! |
|
Please signoff your commits. |
|
Note all commits in the PR needs to be signoff. |
…it is being used (fix tikv#449) Signed-off-by: Eran Rundstein <[email protected]>
eranrund
force-pushed
the
eranrund/fix-449
branch
from
03a35e9 to
1e9392f
Compare
|
Rebased and force-pushed to fix that @BusyJay |
BusyJay
changed the title
|
Thank you for moving quickly on merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression introduced by 0bb4c60#diff-fc1b9721ad58e6a299d6d6633dbc46caR335 and documented on #449