Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve options and documentation #202

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve options and documentation #202

wants to merge 6 commits into from

Conversation

t11r
Copy link
Contributor

@t11r t11r commented Jan 7, 2025

No description provided.

@t11r t11r requested review from ipf, ubbo, paulpestov and jfrer January 7, 2025 18:57
@t11r t11r force-pushed the improve-options branch 4 times, most recently from e18940a to d721f50 Compare January 7, 2025 19:51
@paulpestov
Copy link
Contributor

How is the the null handled in toggleView when it was 'scan' before? And what is the point of this kind of change?

@t11r
Copy link
Contributor Author

t11r commented Jan 8, 2025

Before, both '' and 'scan' meant the same, but for all other options, default values are denoted by null, removing the key from the URL query; for view, it was the rather unpleasant { view: '' }. The old format originated from times when the default view was info, which we changed to scan years ago.

t11r added 2 commits January 8, 2025 15:15
No longer treat view option "scan" and null the same; "scan" is no longer a valid value. Handle URL param for backwards compatibility.
@t11r t11r force-pushed the improve-options branch from d721f50 to 4d7cc4c Compare January 8, 2025 14:15
@t11r t11r force-pushed the improve-options branch 8 times, most recently from b289c4d to 341ea5d Compare January 9, 2025 11:09
@t11r t11r changed the title Improve options Improve options and documentation Jan 9, 2025
@t11r t11r force-pushed the improve-options branch 3 times, most recently from 9e4d652 to 166724b Compare January 9, 2025 18:39
t11r added 2 commits January 9, 2025 19:49
Making missing documentation obvious while keeping main.js and the readme tidy.
To keep things simple and with translation tools widely available, all documentation is only provided in English.
@t11r t11r force-pushed the improve-options branch from 166724b to c353601 Compare January 9, 2025 18:49
@t11r t11r self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants