-
Notifications
You must be signed in to change notification settings - Fork 5
feat(dvfs): update Dvfs trait #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ytakano
wants to merge
20
commits into
main
Choose a base branch
from
fix_dvfs_trait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuuki Takano <[email protected]>
I added four methods to Dvfs.
Additionally, update the return value of convention methods to return pub trait Dvfs {
/// Fix the frequency of the current CPU.
///
/// If current driver does not support this operation,
/// it will return `false`.
fn fix_freq(freq: u64) -> bool {
false
}
/// Get the maximum frequency of the current CPU.
///
/// If current driver does not support this operation,
/// it will return `None`.
fn get_max_freq() -> Option<u64> {
None
}
/// Get the frequency of the current CPU.
///
/// If current driver does not support this operation,
/// it will return `None`.
fn get_curr_freq() -> Option<u64> {
None
}
/// Select the Minimum Performance.
/// (range from 0, lowest performant, through 100, highest performance)
///
/// If current driver does not support this operation,
/// it will return `false`.
fn set_min_performance(min: u8) -> bool {
false
}
/// Get the Minimum Performance.
/// (range from 0, lowest performant, through 100, highest performance)
///
/// If current driver does not support this operation,
/// it will return `None`.
fn get_min_performance() -> Option<u8> {
None
}
/// Set the Maximum Performance.
/// (range from 0, lowest performant, through 100, highest performance)
///
/// If current driver does not support this operation,
/// it will return `false`.
fn set_max_performance(max: u8) -> bool {
false
}
/// Get the Maximum Performance.
/// (range from 0, lowest performant, through 100, highest performance)
///
/// If current driver does not support this operation,
/// it will return `None`.
fn get_max_performance() -> Option<u8> {
None
}
} |
@ytakano |
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Signed-off-by: Yuuki Takano <[email protected]>
Add pub trait Dvfs {
fn set_min_max_performance();
} |
Signed-off-by: Yuuki Takano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
How was this PR tested?
Notes for reviewers