Skip to content

Conversation

@mattwarkentin
Copy link
Contributor

Fixed #166

@mattwarkentin
Copy link
Contributor Author

mattwarkentin commented Oct 10, 2025

I think I've found one more minor issue, let me see if I can find the solution...

EDIT: The grade of "C" was hard-coded here:

value = "C",

Fixed in 6af2a27

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thank you for making this happen, @mattwarkentin. :)

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few logging-related failures in live-api.yaml—don't have a moment to debug at the moment, but should be able to come back to this in coming days.

── Warning ('test-translate.R:192:3'): vitals writes valid logs with numeric solver results (#145) ──
running command ''python' /home/runner/work/vitals/vitals/check/vitals.Rcheck/vitals/test/validate_log.py /tmp/RtmpdIcUqF/working_dir/Rtmp5Tknrd/file208d1c30a4f9/2025-10-19T17-15-11+00-00_simple-dataset_98a176309c3d2361f01390.json 2>&1' had status 1
Backtrace:
    ▆
 1. └─vitals:::expect_valid_log(log_path) at test-translate.R:192:3
 2.   └─base::system2(...) at tests/testthat/helper-valid_log.R:64:5

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-translate.R:192:3'): vitals writes valid logs with numeric solver results (#145) ──
Error in `glue(str, .envir = .envir, .transformer = transformer, .cli = TRUE, 
    .trim = .trim)`: Unterminated quote (')

@simonpcouch simonpcouch merged commit acb57b0 into tidyverse:main Oct 20, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential logging issue with custom generate_*() function

2 participants