Skip to content

add comments to date translation to clarify non-SQL origins (months(), days() on Postgres + Snowflake) #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add comments to date translation to clarify non-SQL origins (months(), days() on Postgres + Snowflake) #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fe65c9
add comments to characterize the intended non-SQL roots for months() …
fh-mthomson Apr 11, 2024
f721367
simplify
fh-mthomson Apr 11, 2024
90df54b
Merge branch 'tidyverse:main' into mthomson/months_not_lubridate
fh-mthomson May 2, 2024
2cc458f
linebreak
fh-mthomson May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/backend-postgres.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,14 @@ sql_translation.PqConnection <- function(con) {
postgres_period(x, "hours")
},
days = function(x) {
# lubridate::days() (base::days() does not exist)
postgres_period(x, "days")
},
weeks = function(x) {
postgres_period(x, "weeks")
},
months = function(x) {
# base::months() (or applicable methods from lubridate, e.g., months.numeric)
postgres_period(x, "months")
},
years = function(x) {
Expand Down
6 changes: 3 additions & 3 deletions R/backend-snowflake.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ sql_translation.Snowflake <- function(con) {
str_squish = function(string) {
sql_expr(regexp_replace(trim(!!string), "\\\\s+", " "))
},


# lubridate functions
# date functions (e.g., from lubridate or ?base::weekdays)
# https://docs.snowflake.com/en/sql-reference/functions-date-time.html
day = function(x) {
sql_expr(EXTRACT(DAY %FROM% !!x))
Expand Down Expand Up @@ -188,12 +186,14 @@ sql_translation.Snowflake <- function(con) {
glue_sql2(sql_current_con(), "INTERVAL '{.val x} hour'")
},
days = function(x) {
# lubridate::days() (base::days() does not exist)
glue_sql2(sql_current_con(), "INTERVAL '{.val x} day'")
},
weeks = function(x) {
glue_sql2(sql_current_con(), "INTERVAL '{.val x} week'")
},
months = function(x) {
# base::months() (or applicable methods from lubridate, e.g., months.numeric)
glue_sql2(sql_current_con(), "INTERVAL '{.val x} month'")
},
years = function(x) {
Expand Down