Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toggle_sparsity() #281

Merged
merged 13 commits into from
Jan 17, 2025
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ Imports:
lifecycle (>= 1.0.3),
modelenv (>= 0.1.0),
parsnip (>= 1.2.1.9000),
recipes (>= 1.0.10.9000),
rlang (>= 1.1.0),
tidyselect (>= 1.2.0),
sparsevctrs (>= 0.1.0.9002),
sparsevctrs (>= 0.1.0.9003),
vctrs (>= 0.4.1),
withr
Suggests:
Expand All @@ -42,7 +43,6 @@ Suggests:
methods,
modeldata (>= 1.0.0),
probably,
recipes (>= 1.0.10.9000),
rmarkdown,
testthat (>= 3.0.0)
VignetteBuilder:
Expand Down
2 changes: 2 additions & 0 deletions R/fit.R
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ fit.workflow <- function(object, data, ..., calibration = NULL, control = contro
)
}

object <- toggle_sparsity(object, data)

workflow <- object
workflow <- .fit_pre(workflow, data)
workflow <- .fit_model(workflow, control)
Expand Down
90 changes: 90 additions & 0 deletions R/sparsevctrs.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,93 @@
is_sparse_matrix <- function(x) {
methods::is(x, "sparseMatrix")
}

toggle_sparsity <- function(object, data) {
if (
allow_sparse(object$fit$actions$model$spec) &&
has_preprocessor_recipe(object)
) {
est_sparsity <- recipes::.recipes_estimate_sparsity(
extract_preprocessor(object)
)

toggle_sparse <- should_use_sparsity(
est_sparsity,
extract_spec_parsnip(object)$engine,
nrow(data)
)

object$pre$actions$recipe$recipe <- recipes::.recipes_toggle_sparse_args(
object$pre$actions$recipe$recipe,
choice = toggle_sparse
)
}

object
}

allow_sparse <- function(x) {
if (inherits(x, "model_fit")) {
x <- x$spec

Check warning on line 31 in R/sparsevctrs.R

View check run for this annotation

Codecov / codecov/patch

R/sparsevctrs.R#L31

Added line #L31 was not covered by tests
}
res <- parsnip::get_from_env(paste0(class(x)[1], "_encoding"))
all(res$allow_sparse_x[res$engine == x$engine])
}

# This function was created using from the output of a mars model fit on the
# simulation data generated in `analysis/time_analysis.R`
# https://github.com/tidymodels/benchmark-sparsity-threshold
#
# The model was extracted using {tidypredict} and hand-tuned for speed.
#
# The model was fit on `sparsity`, `engine` and `n_rows` and the outcome was
# `log_fold` which is defined as
# `log(time to fit with dense data / time to fit with sparse data)`.
# Meaning that values above above 0 would reflects longer fit times for dense,
# Hence we want to use sparse data.
#
# At this time the only engines that support sparse data are glmnet, LiblineaR,
# ranger, and xgboost. Which is why they are the only ones listed here.
# This is fine as this code will only run if `allow_sparse()` returns `TRUE`
# Which only happens for these engines.
#
# Ranger is hard-coded to always fail since they appear to use the same
# algorithm for sparse and dense data, resulting in identical times.
should_use_sparsity <- function(sparsity, engine, n_rows) {
if (is.null(engine) || engine == "ranger") {
return("no")

Check warning on line 58 in R/sparsevctrs.R

View check run for this annotation

Codecov / codecov/patch

R/sparsevctrs.R#L58

Added line #L58 was not covered by tests
EmilHvitfeldt marked this conversation as resolved.
Show resolved Hide resolved
}

log_fold <- -0.599333138645995 +
ifelse(sparsity < 0.836601307189543, 0.836601307189543 - sparsity, 0) *
-0.541581853008009 +
ifelse(n_rows < 16000, 16000 - n_rows, 0) * 3.23980908942813e-05 +
ifelse(n_rows > 16000, n_rows - 16000, 0) * -2.81001152147355e-06 +
ifelse(sparsity > 0.836601307189543, sparsity - 0.836601307189543, 0) *
9.82444255114058 +
ifelse(sparsity > 0.836601307189543, sparsity - 0.836601307189543, 0) *
ifelse(n_rows > 8000, n_rows - 8000, 0) *
7.27456967763306e-05 +
ifelse(sparsity > 0.836601307189543, sparsity - 0.836601307189543, 0) *
ifelse(n_rows < 8000, 8000 - n_rows, 0) *
-0.000798307404212627

if (engine == "xgboost") {
log_fold <- log_fold +
ifelse(sparsity < 0.984615384615385, 0.984615384615385 - sparsity, 0) *
0.113098025073806 +
ifelse(n_rows < 8000, 8000 - n_rows, 0) * -9.77914237255269e-05 +
ifelse(n_rows > 8000, n_rows - 8000, 0) * 3.22657666511869e-06 +
ifelse(sparsity > 0.984615384615385, sparsity - 0.984615384615385, 0) *
41.5180348086939 +
0.913457808326756

Check warning on line 83 in R/sparsevctrs.R

View check run for this annotation

Codecov / codecov/patch

R/sparsevctrs.R#L76-L83

Added lines #L76 - L83 were not covered by tests
}

if (engine == "LiblineaR") {
log_fold <- log_fold +
ifelse(sparsity > 0.836601307189543, sparsity - 0.836601307189543, 0) *
-5.39592564852111

Check warning on line 89 in R/sparsevctrs.R

View check run for this annotation

Codecov / codecov/patch

R/sparsevctrs.R#L87-L89

Added lines #L87 - L89 were not covered by tests
}

ifelse(log_fold > 0, "yes", "no")
}
Loading