Merge pull request #196 from tidymodels/parsnip-update-2025

tidymodels · Jan 27, 2025 · a928d70 · a928d70
2 parents 8881f14 + f7a771c
commit a928d70
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -17,7 +17,7 @@ Depends:
     R (>= 3.6)
 Imports: 
     cli (>= 3.0.0),
-    dials (>= 1.1.0),
+    dials (>= 1.3.0),
     dplyr (>= 1.0.9),
     flexclust (>= 1.3-6),
     foreach,

diff --git a/R/arguments.R b/R/arguments.R
@@ -101,7 +101,7 @@ set_args.cluster_spec <- function(object, ...) {
 #' @inheritParams parsnip::set_mode
 #' @return An updated [`cluster_spec`] object.
 #' @export
-set_mode.cluster_spec <- function(object, mode) {
+set_mode.cluster_spec <- function(object, mode, ...) {
   cls <- class(object)[1]
   if (rlang::is_missing(mode)) {
     spec_modes <- rlang::env_get(

diff --git a/R/tune_cluster.R b/R/tune_cluster.R
@@ -1066,7 +1066,7 @@ check_grid <- function(grid, workflow, pset = NULL) {
     }
     check_workflow(workflow, pset = pset, check_dials = TRUE)
 
-    grid <- dials::grid_latin_hypercube(pset, size = grid)
+    grid <- dials::grid_space_filling(pset, size = grid)
     grid <- dplyr::distinct(grid)
   }
 

diff --git a/man/set_args.cluster_spec.Rd b/man/set_args.cluster_spec.Rd
diff --git a/man/set_engine.cluster_spec.Rd b/man/set_engine.cluster_spec.Rd
diff --git a/man/set_mode.cluster_spec.Rd b/man/set_mode.cluster_spec.Rd
diff --git a/tests/testthat/_snaps/tune_cluster.md b/tests/testthat/_snaps/tune_cluster.md
@@ -113,17 +113,14 @@
     Condition
       Warning:
       The `...` are not used in this function but one or more objects were passed: 'something'
-      Warning:
-      `grid_latin_hypercube()` was deprecated in dials 1.3.0.
-      i Please use `grid_space_filling()` instead.
     Output
       # Tuning results
       # 2-fold cross-validation 
       # A tibble: 2 x 4
         splits          id    .metrics         .notes          
         <list>          <chr> <list>           <list>          
-      1 <split [16/16]> Fold1 <tibble [4 x 5]> <tibble [0 x 3]>
-      2 <split [16/16]> Fold2 <tibble [4 x 5]> <tibble [0 x 3]>
+      1 <split [16/16]> Fold1 <tibble [6 x 5]> <tibble [0 x 3]>
+      2 <split [16/16]> Fold2 <tibble [6 x 5]> <tibble [0 x 3]>
 
 # select_best() and show_best() works
 

diff --git a/tidyclust.Rproj b/tidyclust.Rproj
@@ -1,4 +1,5 @@
 Version: 1.0
+ProjectId: 7aa6e982-3f23-4734-8da7-2ab97b3d66a5
 
 RestoreWorkspace: No
 SaveWorkspace: No