Merge pull request #276 from tidymodels/rlang-type-checkers

use rlang type checkers
tidymodels · Nov 11, 2024 · a7700f0 · a7700f0
2 parents d52874a + f3b5443
commit a7700f0
Show file tree

Hide file tree

Showing 67 changed files with 1,868 additions and 47 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -29,7 +29,7 @@ Imports:
     magrittr,
     Matrix,
     purrr,
-    rlang,
+    rlang (>= 1.1.0),
     SnowballC,
     tibble,
     tokenizers,

diff --git a/NAMESPACE b/NAMESPACE
@@ -172,7 +172,6 @@ importFrom(purrr,map_lgl)
 importFrom(purrr,pmap)
 importFrom(recipes,add_step)
 importFrom(recipes,bake)
-importFrom(recipes,check_name)
 importFrom(recipes,check_new_data)
 importFrom(recipes,check_type)
 importFrom(recipes,get_keep_original_cols)

diff --git a/R/dummy_hash.R b/R/dummy_hash.R
@@ -157,6 +157,10 @@ step_dummy_hash_new <-
 prep.step_dummy_hash <- function(x, training, info = NULL, ...) {
   col_names <- recipes_eval_select(x$terms, training, info)
 
+  check_bool(x$signed, arg = "signed")
+  check_number_whole(x$num_terms, min = 0, arg = "num_terms")
+  check_bool(x$collapse, arg = "collapse")
+
   check_type(training[, col_names], types = c("string", "factor", "ordered"))
 
   step_dummy_hash_new(
@@ -213,7 +217,7 @@ bake.step_dummy_hash <- function(object, new_data, ...) {
       )
 
     tf_text <- purrr::map_dfc(tf_text, as.integer)
-    tf_text <- check_name(tf_text, new_data, object, names(tf_text))
+    tf_text <- recipes::check_name(tf_text, new_data, object, names(tf_text))
 
     new_data <- vec_cbind(new_data, tf_text)
   }