Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending the call to check_data_frame_or_matrix() #277

Merged
merged 20 commits into from
Jan 23, 2025
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jan 23, 2025

Part of addressing #274

This PR aims to pass all relevant calls to the check_*() function, which is called by the most other functions in hardhat, check_data_frame_or_matrix(): 53 other functions call it, with the paths to get there being made up of 85 edges.

Notable changes along the way are the following exported functions gaining a call argument:

  • model_frame()
  • model_matrix()
  • scream()
  • check_outcomes_are_numeric()
  • check_outcomes_are_factors()
  • check_outcomes_are_binary()
  • check_predictors_are_numeric()
  • check_prediction_size()
  • extract_ptype()
  • get_data_classes()
  • add_intercept_column()

@hfrick hfrick merged commit 7aaa32f into main Jan 23, 2025
14 checks passed
@hfrick hfrick deleted the more-error-calls branch January 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant