Skip to content

Conversation

Wander03
Copy link

@kbodwin

Adds new function for min_support to dials to support adding freq_itemsets to tidyclust, see tidymodels/tidyclust#210

@hfrick
Copy link
Member

hfrick commented Jun 24, 2025

Thank you for the PR! Similarly to #389, I've kicked off the actions on it but I'll hold of reviewing until Emil has had a chance to look at the corresponding tidyclust PR.

@kbodwin
Copy link

kbodwin commented Jun 29, 2025

Quick note on the comment on line 16 of param_min_support - we believe this param would be better using finalize, but it was out-of-scope for the project this year. It works fine now and defaults to reasonable values; just noting for a future upgrade.

@hfrick
Copy link
Member

hfrick commented Jul 3, 2025

@kbodwin Could you turn that into an issue instead of the code comment? That makes it much easier to keep track of in the longer term.

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I see Emil has moved on the corresponding tidyclust PR, so I'll add my comments here. This looks good! In addition to the point above about turning a code comment into a GH issue, could you please also

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants