Skip to content

feat(android): global DrawerLayout for BottomNavigation #14228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat(android): global DrawerLayout for BottomNavigation #14228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ca9330
feat(android): global DrawerLayout for BottomNavigation
m1ga May 19, 2025
b91c4ce
methods
m1ga May 19, 2025
30d3947
events and update properties
m1ga May 19, 2025
b90bed0
Merge branch 'master' into androidBottomDrawer
m1ga Jun 18, 2025
65a422b
set id strings
m1ga Jun 18, 2025
fdb6015
fix setting views after init
m1ga Jun 20, 2025
cc7963a
Merge branch 'master' into androidBottomDrawer
m1ga Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions android/modules/ui/res/layout/titanium_ui_bottom_navigation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
<androidx.drawerlayout.widget.DrawerLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true">

<FrameLayout
android:id="@+id/bottomNavBar_content"
<RelativeLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_above="@+id/bottomNavBar" />
android:layout_height="match_parent">

<com.google.android.material.bottomnavigation.BottomNavigationView
android:id="@+id/bottomNavBar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_alignParentBottom="true" />
<FrameLayout
android:id="@+id/bottomNavBar_content"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_above="@+id/bottomNavBar" />

<com.google.android.material.bottomnavigation.BottomNavigationView
android:id="@+id/bottomNavBar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_alignParentBottom="true" />

</RelativeLayout>
</RelativeLayout>
</androidx.drawerlayout.widget.DrawerLayout>
52 changes: 51 additions & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@
TiC.PROPERTY_AUTO_TAB_TITLE,
TiC.PROPERTY_EXIT_ON_CLOSE,
TiC.PROPERTY_SMOOTH_SCROLL_ON_TAB_CLICK,
TiC.PROPERTY_INDICATOR_COLOR
TiC.PROPERTY_INDICATOR_COLOR,
TiC.PROPERTY_LEFT_VIEW,
TiC.PROPERTY_RIGHT_VIEW
})
public class TabGroupProxy extends TiWindowProxy implements TiActivityWindow
{
Expand Down Expand Up @@ -780,6 +782,54 @@ public void fireSafeAreaChangedEvent()
}
}

@Kroll.method
public void toggleLeft()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.toggleLeft();
}
}

@Kroll.method
public void openLeft()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.openLeft();
}
}

@Kroll.method
public void closeLeft()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.closeLeft();
}
}

@Kroll.method
public void toggleRight()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.toggleRight();
}
}

@Kroll.method
public void openRight()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.openRight();
}
}

@Kroll.method
public void closeRight()
{
if (view instanceof TiUIBottomNavigation bottomNavigation) {
bottomNavigation.closeRight();
}
}

@Override
public String getApiName()
{
Expand Down
Loading
Loading