Update performance-challenge-program.md #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add personal sign up template
you06
reviewed
Nov 3, 2019
| ## Personal Sign up | ||
|
|
||
| - Self-intoduction: A programmer/student with X years of Rust/Go experience,currently working/studying at XXX. | ||
| - Email: [email protected] |
There was a problem hiding this comment.
Should we check if the email filed is a valid value before signing up?
There was a problem hiding this comment.
IMO, for the people who don't want leaving an email in issue can also sign up.
There was a problem hiding this comment.
Yes, we need to verify the validity of the mailbox. People who don't want leaving an email in issue can also sign up.
There was a problem hiding this comment.
If whether the email verify is sucess or not, signning up is always success, why we should verify it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@you06 PTAL