Skip to content

修复 workspace 浏览页初始化后不加载目录 #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiann merged 3 commits into from
May 10, 2026
+7 −3
Merged

修复 workspace 浏览页初始化后不加载目录 #605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48889f4
fix browse workspace root loading
sleepinginsummer May 9, 2026
6240238
fix workspace root dependency stability
sleepinginsummer May 10, 2026
5b3746a
avoid resetting browse state on metadata refresh
sleepinginsummer May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions web/src/components/WorkspaceBrowser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,10 @@ export function WorkspaceBrowser(props: {
() => machineId ? machines.find(m => m.id === machineId) ?? null : null,
[machineId, machines]
)
const workspaceRoots = selectedMachine?.metadata?.workspaceRoots ?? []
const workspaceRoots = useMemo(
() => selectedMachine?.metadata?.workspaceRoots ?? [],
[selectedMachine?.metadata?.workspaceRoots]
)

const loadDirectory = useCallback(async (path: string) => {
if (!machineId) return
Expand Down Expand Up @@ -226,9 +229,10 @@ export function WorkspaceBrowser(props: {
void loadDirectory(selectedRoot)
}, [machineId, selectedRoot, currentPath, loadDirectory])

// If switching machines, reset view
// 切换机器时才重置浏览状态；workspaceRoots 的刷新由上面的 effect
// 只做 root 有效性校正，避免 metadata 更新时清空用户当前浏览位置。
useEffect(() => {
setSelectedRoot(null)
setSelectedRoot(workspaceRoots[0] ?? null)
setCurrentPath(null)
setEntries([])
setError(null)
Expand Down
Loading