-
-
Notifications
You must be signed in to change notification settings - Fork 429
feat(cli): add global option to disable automatic session title changes #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
fe3b914
726bbdd
559c5d5
2b7a016
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,13 @@ | ||
| /** | ||
| * Codex-specific system prompt for local mode. | ||
| * | ||
| * This prompt instructs Codex to call the hapi__change_title function | ||
| * to set appropriate chat session titles. | ||
| */ | ||
|
|
||
| import { trimIdent } from '@/utils/trimIdent'; | ||
| import { shouldEnableAutoTitle } from '@/claude/utils/claudeSettings'; | ||
|
|
||
| /** | ||
| * Title instruction for Codex to call the hapi MCP tool. | ||
| * Note: Codex exposes MCP tools under the `functions.` namespace, | ||
| * so the tool is called as `functions.hapi__change_title`. | ||
| */ | ||
| export const TITLE_INSTRUCTION = trimIdent(` | ||
| export const TITLE_INSTRUCTION = shouldEnableAutoTitle() | ||
| ? trimIdent(` | ||
| ALWAYS when you start a new chat, call the title tool to set a concise task title. | ||
| Prefer calling functions.hapi__change_title. | ||
| If that exact tool name is unavailable, call an equivalent alias such as hapi__change_title, mcp__hapi__change_title, or hapi_change_title. | ||
| If the task focus changes significantly later, call the title tool again with a better title. | ||
| `); | ||
| `) | ||
| : ''; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [MAJOR] When Suggested fix: // cli/src/codex/codexLocal.ts
if (codexSystemPrompt) {
args.push(...buildDeveloperInstructionsArg(codexSystemPrompt));
}
// cli/src/codex/utils/appServerConfig.ts
const developerInstructions = [baseInstructions, args.developerInstructions]
.filter(Boolean)
.join('\n\n');
const configWithInstructions = {
...config,
...(developerInstructions ? { developer_instructions: developerInstructions } : {}),
...(args.mode.modelReasoningEffort ? { model_reasoning_effort: args.mode.modelReasoningEffort } : {})
}; |
||
|
|
||
| /** | ||
| * The system prompt to inject via developer_instructions in local mode. | ||
| */ | ||
| export const codexSystemPrompt = TITLE_INSTRUCTION; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,10 @@ | ||
| /** | ||
| * OpenCode-specific system prompt for change_title tool. | ||
| * | ||
| * OpenCode exposes MCP tools with the naming pattern: <server-name>_<tool-name> | ||
| * The hapi MCP server exposes `change_title`, so it's called as `hapi_change_title`. | ||
| */ | ||
|
|
||
| import { trimIdent } from '@/utils/trimIdent'; | ||
| import { shouldEnableAutoTitle } from '@/claude/utils/claudeSettings'; | ||
|
|
||
| /** | ||
| * Title instruction for OpenCode to call the hapi MCP tool. | ||
| */ | ||
| export const TITLE_INSTRUCTION = trimIdent(` | ||
| export const TITLE_INSTRUCTION = shouldEnableAutoTitle() | ||
| ? trimIdent(` | ||
| ALWAYS when you start a new chat - you must call the tool "hapi_change_title" to set a chat title. When you think chat title is not relevant anymore - call the tool again to change it. When chat name is too generic and you have a chance to make it more specific - call the tool again to change it. This title is needed to easily find the chat in the future. Help human. | ||
| `); | ||
| `) | ||
| : ''; | ||
|
|
||
| /** | ||
| * The system prompt to inject for OpenCode sessions. | ||
| */ | ||
| export const opencodeSystemPrompt = TITLE_INSTRUCTION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MAJOR]
enableAutoTitle=falseonly removes the tool from the HTTP MCP server here. Codex and OpenCode still go throughbuildHapiMcpBridge(...), andcli/src/codex/happyMcpStdioBridge.ts:72still unconditionally re-registerschange_title, so those modes can still see and call the title tool.Suggested fix:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in next commit