feat(verifier): support repository-scoped static host aliases - #145
Merged
Conversation
Closes #143 Signed-off-by: tiammomo <26957354+tiammomo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Provide repository-scoped static IPv4 aliases for mocked HTTP test hostnames while keeping verifier containers offline.
Read verification_hosts only from trusted user configuration. Validate hostname labels, literal IPv4 addresses and canonical duplicates; bind aliases to the repository policy and sandbox manifest. Pass structured Docker --add-host arguments to bootstrap and verification without changing isolation flags. Cover trust boundaries, argument construction and both execution phases; serialize the new table correctly in the real MCP transport fixture. Pre-commit verification passed 607 tests, lint, formatting, CLI smoke and build. This enables offline deer-flow Browserless tests that otherwise fail before reaching their mocked client.
Verified with
uv run --python 3.12 python -W error::ResourceWarning -m unittest discover -s tests -v,uvx ruff check .,uvx ruff format --check .,uv run reposteward --help,uv build --offline.Areas for careful review:
Implementation assistance: an external coding workspace was used to prepare the change and its
tests.
tiammomoreviewed the final diff, understands it, and takes responsibilityfor this contribution.