fix(verifier): accept bounded API key placeholders - #142
Merged
Conversation
Closes #141 Signed-off-by: tiammomo <26957354+tiammomo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
Accept strict your-provider-api-key placeholders in tracked environment templates so public example files can enter isolated verification.
Extend the bounded full-match placeholder policy alongside the existing replace-with format. Preserve all filename, encoding, size, regular-file, directory and sensitive-value checks. Regression coverage includes public provider placeholders, multi-part provider names, the exact 128-character boundary, and malformed or sensitive-looking values. The new regression failed before the fix; isolated pre-commit validation passed all 603 tests, lint, formatting, CLI smoke and build.
Verified with
uv run --python 3.12 python -W error::ResourceWarning -m unittest discover -s tests -v,uvx ruff check .,uvx ruff format --check .,uv run reposteward --help,uv build --offline.Areas for careful review:
Implementation assistance: an external coding workspace was used to prepare the change and its
tests.
tiammomoreviewed the final diff, understands it, and takes responsibilityfor this contribution.