-
Notifications
You must be signed in to change notification settings - Fork 5
Add fetchPackageVersionDependencies function to thunderstore-api #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { expect, test } from "vitest"; | ||
| import { config, testData } from "../../__tests__/defaultConfig"; | ||
| import { fetchPackageVersionDependencies } from "../packageVersionDependencies"; | ||
| import { packageVersionDependenciesResponseDataSchema } from "../.."; | ||
|
|
||
| // TODO: Disabled temporarily until we decide on a testing strategy/policy regarding e2e tests | ||
| test.skip("ensures package version dependencies can be fetched", async () => { | ||
| const { namespaceId, packageName, versionNumber } = testData; | ||
| const response = await fetchPackageVersionDependencies({ | ||
| config, | ||
| params: { | ||
| namespace_id: namespaceId, | ||
| package_name: packageName, | ||
| version_number: versionNumber, | ||
| }, | ||
| data: {}, | ||
| queryParams: [{ key: "page", value: 1, impotent: 1 }], | ||
| }); | ||
|
|
||
| expect(response.count).toBe(3); | ||
| expect(response.results.length).toBe(3); | ||
| expect(packageVersionDependenciesResponseDataSchema.parse(response)).toEqual( | ||
| response | ||
| ); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { | ||
| ApiEndpointProps, | ||
| packageVersionDependenciesRequestQueryParamsSchema, | ||
| PackageVersionDependenciesRequestQueryParams, | ||
| PackageVersionDependenciesRequestParams, | ||
| packageVersionDependenciesResponseDataSchema, | ||
| PackageVersionDependenciesResponseData, | ||
| } from "../index"; | ||
| import { apiFetch } from "../apiFetch"; | ||
|
|
||
| export async function fetchPackageVersionDependencies( | ||
| props: ApiEndpointProps< | ||
| PackageVersionDependenciesRequestParams, | ||
| PackageVersionDependenciesRequestQueryParams, | ||
| object | ||
| > | ||
| ): Promise<PackageVersionDependenciesResponseData> { | ||
| const { | ||
| config, | ||
| params, | ||
| queryParams = [{ key: "page", value: 1, impotent: 1 }], | ||
| } = props; | ||
| const path = `api/cyberstorm/package/${params.namespace_id}/${params.package_name}/v/${params.version_number}/dependencies/`; | ||
|
|
||
| return await apiFetch({ | ||
| args: { | ||
| config, | ||
| path, | ||
| queryParams, | ||
| }, | ||
| requestSchema: undefined, | ||
| queryParamsSchema: packageVersionDependenciesRequestQueryParamsSchema, | ||
| responseSchema: packageVersionDependenciesResponseDataSchema, | ||
| }); | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,6 +18,7 @@ import { | |||||||||||||||||||||||||||||||||||
| packageWikiPageSchema, | ||||||||||||||||||||||||||||||||||||
| packagePermissionsSchema, | ||||||||||||||||||||||||||||||||||||
| packageSourceSchema, | ||||||||||||||||||||||||||||||||||||
| packageVersionDependencySchema, | ||||||||||||||||||||||||||||||||||||
| } from "../schemas/objectSchemas"; | ||||||||||||||||||||||||||||||||||||
| import { paginatedResults } from "../schemas/objectSchemas"; | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
|
|
@@ -139,6 +140,17 @@ export type PackageVersionsResponseData = z.infer< | |||||||||||||||||||||||||||||||||||
| typeof packageVersionsResponseDataSchema | ||||||||||||||||||||||||||||||||||||
| >; | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| export const packageVersionDependenciesResponseDataSchema = z.object({ | ||||||||||||||||||||||||||||||||||||
| count: z.number(), | ||||||||||||||||||||||||||||||||||||
| next: z.string().url().nullable(), | ||||||||||||||||||||||||||||||||||||
| previous: z.string().url().nullable(), | ||||||||||||||||||||||||||||||||||||
| results: z.array(packageVersionDependencySchema), | ||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| export type PackageVersionDependenciesResponseData = z.infer< | ||||||||||||||||||||||||||||||||||||
| typeof packageVersionDependenciesResponseDataSchema | ||||||||||||||||||||||||||||||||||||
| >; | ||||||||||||||||||||||||||||||||||||
|
Comment on lines
+143
to
+152
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major Use This schema manually defines the pagination structure, but other paginated responses in this file use the Apply this diff: -export const packageVersionDependenciesResponseDataSchema = z.object({
- count: z.number(),
- next: z.string().url().nullable(),
- previous: z.string().url().nullable(),
- results: z.array(packageVersionDependencySchema),
-});
+export const packageVersionDependenciesResponseDataSchema = paginatedResults(
+ packageVersionDependencySchema
+);Note: The helper uses 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| // PackageWikiResponse | ||||||||||||||||||||||||||||||||||||
| export const packageWikiResponseDataSchema = z.object({ | ||||||||||||||||||||||||||||||||||||
| id: z.string().min(1), | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.