Add a option to force currentUser update to getSessionCurrentUser

[Oksamies]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 09-17-add_a_option_to_force_currentuser_update_to_getsessioncurrentuser

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Update thunderstore-api to match up coming cyberstorm API changes #1542 : 2 dependent PRs (#1543 , #1547 )
• Add forced currentUser update to settings and teams pages #1535
• Add a option to force currentUser update to getSessionCurrentUser #1541 👈 (View in Graphite)
• Ensure current user is updated #1540
• Fix session revalidation corner case #1539
• Fix setSsion stale value set #1538
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[anttimaki]

Not a blocker but would be mighty cool of you if you'd at least consider doing the suggested changes if they make sense to you. And "it can be done later" is a cheap copout.

[anttimaki]

Nitpicks:

1. There's no need to read isStale if forceUpdateCurrentUser is true
2. The pattern of !(x === y) sort of read out like no(yes), which IMO is a bit confusing. Why not just use x !== y?
3. Using the strict equality operator (===) in isStale === "no" already checks for the type, so the check with typeof is redundant

Put together, this would reduce into

if (forceUpdateCurrentUser || _storage.safeGetValue(STALE_KEY) !== "no") {

Is guaranteed to return either "yes" or "no" (i.e. no undefined oslt), it might be better to use _storage.safeGetValue(STALE_KEY) === "yes" to avoid that "not 'no'" scenario again.

[Oksamies]

ESLint and CodeQL checks are failing because Graphite created a temporary branch when I was fixing and submitting code in each PR in order. (someone has limited the maximum amount of pushes to 2 in a single command and graphite normally tries to do the whole stack at once to prevent needing to create temporary branches)