Fix Team Settings pages breadcrumb linkId

[Oksamies]

oops

Summary by CodeRabbit

• Bug Fixes
  • Corrected the breadcrumb label in Team settings to display “Team Settings” for improved accuracy and consistency across navigation.
  • Ensures the breadcrumb trail reflects the correct destination when browsing Team settings, reducing confusion for users.
  • No changes to functionality or navigation flow—only the displayed label is updated for clarity.

[coderabbitai]

Walkthrough

Breadcrumb configuration updated in apps/cyberstorm-remix/app/root.tsx: the NewBreadCrumbsLink prop linkId was changed from "Team" to "TeamSettings" within the Team settings layout. No control flow, API surface, or exports were altered.

Changes

Cohort / File(s)	Summary
Breadcrumb linkId adjustment apps/cyberstorm-remix/app/root.tsx	Updated NewBreadCrumbsLink prop linkId from "Team" to "TeamSettings" in Team settings breadcrumb configuration; no other logic or exports changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Add Breadcrumbs for settings pages #1534: Adjusts breadcrumbs to be TeamSettings-aware, directly related to changing linkId to "TeamSettings".
• Remove old Breadcrumbs from settings pages #1533: Alters breadcrumb usage for team/settings pages, overlapping with this breadcrumb update.

Suggested reviewers

• VilppeRiskidev

Poem

I nibbled the crumbs along the trail,
Swapped “Team” for “TeamSettings” without fail.
A tiny hop, a tidy string,
Breadcrumbs align—what joy they bring!
Thump-thump goes my codey heart,
Onward to routes where journeys start. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Fix Team Settings pages breadcrumb linkId" succinctly and accurately describes the primary change—updating the breadcrumb linkId for the Team Settings pages (changing "Team" to "TeamSettings")—and is clear and specific enough for a reviewer scanning history.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 09-17-fix_team_settings_pages_breadcrumb_linkid

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Oksamies]

• Fix Team Settings pages breadcrumb linkId #1537 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

apps/cyberstorm-remix/app/root.tsx (2)

358-366: Show the Team Settings crumb on nested tabs too

Right now the Team Settings crumb only renders on the base teamSettingsPage. Consider including the tab matches so it appears on Profile/Members/ServiceAccounts/Settings subroutes.

Apply within this block:

-                        {teamSettingsPage ? (
+                        {(teamSettingsPage ||
+                          teamSettingsProfilePage ||
+                          teamSettingsMembersPage ||
+                          teamSettingsServiceAccountsPage ||
+                          teamSettingsSettingsPage) ? (
                           <NewBreadCrumbsLink
                             primitiveType="cyberstormLink"
-                            linkId="TeamSettings"
+                            linkId="TeamSettings"
                             csVariant="cyber"
-                            team={teamSettingsPage.params.namespaceId}
+                            team={
+                              teamSettingsPage?.params.namespaceId ??
+                              teamSettingsProfilePage?.params.namespaceId ??
+                              teamSettingsMembersPage?.params.namespaceId ??
+                              teamSettingsServiceAccountsPage?.params.namespaceId ??
+                              teamSettingsSettingsPage?.params.namespaceId
+                            }
                           >
-                            {teamSettingsPage.params.namespaceId}
+                            {teamSettingsPage?.params.namespaceId ??
+                              teamSettingsProfilePage?.params.namespaceId ??
+                              teamSettingsMembersPage?.params.namespaceId ??
+                              teamSettingsServiceAccountsPage?.params.namespaceId ??
+                              teamSettingsSettingsPage?.params.namespaceId}
                           </NewBreadCrumbsLink>
                         ) : null}

---

136-139: Typo in user‑facing error message

"Enviroment" → "Environment".

-      "Enviroment variables did not load correctly, please hard refresh page"
+      "Environment variables did not load correctly, please hard refresh page"

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 285c594 and e882b4c.

📒 Files selected for processing (1)

• apps/cyberstorm-remix/app/root.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Test
• GitHub Check: Generate visual diffs
• GitHub Check: CodeQL

🔇 Additional comments (1)

apps/cyberstorm-remix/app/root.tsx (1)

358-366: Correct linkId for Team Settings breadcrumb — good fix

Switching linkId to 'TeamSettings' matches the settings routes and should stop breadcrumbs from linking to the public team page.

Repository search returned no results; confirm LinkLibrary contains a 'TeamSettings' entry and that it expects a 'team' param (not 'namespace').

[VilppeRiskidev]

Nice 👍