Add cache lock in Shcemafile.get_or_create (TS-2457) #1154
+67
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Roffenlund
force-pushed
the
schemafile-cache-lock
branch
from
8da7feb to
bc62815
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 92.21% 92.22%
=======================================
Files 331 331
Lines 10060 10065 +5
Branches 926 926
=======================================
+ Hits 9277 9282 +5
Misses 657 657
Partials 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Utilize a redis cache lock when getting or creating a new SchemaFile in order to prevent race conditions. Implement tests. Refs. TS-2457
Roffenlund
force-pushed
the
schemafile-cache-lock
branch
from
bc62815 to
e284559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize a redis cache lock when getting or creating a new SchemaFile in order to prevent race conditions.
Implement tests.
Refs. TS-2457