Update communities in parallel (TS-2378) #1128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roffenlund
commented
Apr 1, 2025
Roffenlund
commented
- Create a main celery task which delegates the cache update for each community to a child task.
- Implement tests.
- Implement migration.
Roffenlund
force-pushed
the
update-communities-in-parallel
branch
from
f134202 to
90c30b0
Compare
Roffenlund
force-pushed
the
update-communities-in-parallel
branch
from
90c30b0 to
baccb0e
Compare
Refactor task for updating chunked community packages to update each community in parallel. Introduce a new task which is spawned by the main update task to fire on each community. Remove function responsible for updating all community caches and introduce a new function doing the same thing but for a single community, taking the community as a parameter. Update cache tests because the old cache update function was removed. Add update_single_community_cache to celery tests. Add a create_batch method to CommunityFactory to help with testing. Add test for the newly updated celery task to assert that the child tasks are indeed spawned per community. Refs. TS-2378
Roffenlund
force-pushed
the
update-communities-in-parallel
branch
from
baccb0e to
e7b3d98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 93.02% 93.06% +0.04%
==========================================
Files 324 324
Lines 9685 9698 +13
Branches 858 859 +1
==========================================
+ Hits 9009 9025 +16
+ Misses 554 552 -2
+ Partials 122 121 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.