-
Couldn't load subscription status.
- Fork 29
Add TACo commitment checks and alerts when topping up or de-authing #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theref
wants to merge
5
commits into
main
Choose a base branch
from
topup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1047cca
Improve condition for Commitment button and display commitment end date
theref 0551ab5
Add wording about commitment to topup modal
theref a0ed037
Show alert when trying to Deauth during Taco commitment period
theref cf36d08
Improve wording when topping up or de-authing
theref fd85b5f
Merge branch 'main' into topup
kpyszkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ import { formatDate } from "../../../../utils/date" | |
| import { calculatePercenteage } from "../../../../utils/percentage" | ||
| import { StakingAppForm } from "../../../../components/StakingApplicationForms" | ||
| import { AuthorizationStatus } from "../../../../types" | ||
| import { StakingProviderInfo } from "../../../../threshold-ts/applications" | ||
|
|
||
| interface CommonProps { | ||
| stakingAppId: StakingAppName | ||
|
|
@@ -58,6 +59,7 @@ type StakingAppAuthDataBaseProps = { | |
| remainingAuthorizationDecreaseDelay: string | ||
| isOperatorInPool: boolean | undefined | ||
| operator: string | ||
| stakingProviderInfo?: StakingProviderInfo | undefined | ||
| } | ||
|
|
||
| type AppAuthDataConditionalProps = | ||
|
|
@@ -255,8 +257,26 @@ export const AuthorizeApplicationsCardCheckboxBase: FC< | |
| } | ||
|
|
||
| const onSubmitForm = (tokenAmount: string) => { | ||
| if (isIncreaseAction) onAuthorizeApp(tokenAmount) | ||
| else onInitiateDeauthorization(tokenAmount) | ||
| if (isIncreaseAction) { | ||
| onAuthorizeApp(tokenAmount) | ||
| } else { | ||
| if (appAuthData.stakingAppId === "taco") { | ||
| // const endCommitment = appAuthData.stakingProviderInfo?.endCommitment | ||
| const endCommitment = appAuthData.stakingProviderInfo?.endCommitment | ||
| const currentTime = Math.floor(Date.now() / 1000) | ||
| const isCommited = (Number(endCommitment) ?? 0) > currentTime | ||
| const endCommitmentDate = new Date( | ||
| (Number(endCommitment) ?? 0) * 1000 | ||
| ).toLocaleDateString() | ||
| if (isCommited) { | ||
| alert(`You are still committed until ${endCommitmentDate}.`) | ||
theref marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } else { | ||
| onInitiateDeauthorization(tokenAmount) | ||
| } | ||
| } else { | ||
| onInitiateDeauthorization(tokenAmount) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| const onConfirmDeauthorization = () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.