Skip to content

Conversation

@theref
Copy link
Member

@theref theref commented Nov 13, 2023

isDeauthorizationReqestActive -> isDeauthorizationRequestActive

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to look at before the merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Unrelated to the file]

Let's also change this typo in those two places:

and

Without those changes the error appears here:

tbtc: {
...tbtcApp,
stakingAppId: "tbtc",
address: tbtcAppAddress,
label: "tBTC",
},
randomBeacon: {
...randomBeaconApp,
stakingAppId: "randomBeacon",
address: randomBeaconAddress,
label: "Random Beacon",
},

remainingAuthorizationDecreaseDelay:
_appData.remainingAuthorizationDecreaseDelay.toString(),
isDeauthorizationReqestActive: _appData.isDeauthorizationReqestActive,
isDeauthorizationRequestActive: _appData.isDeauthorizationRequestActive,
Copy link
Contributor

@michalsmiarowski michalsmiarowski Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds are failing because code is not formatted. Please run yarn format:fix to fix that.

If you do that (and just that) in a separate commit, then additionaly add that commit hash to .git-blame-ignore-revs file.

node_modules/
yarn-error.log

.cosine/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this directory? 🤔

* In that case we can't estimate when the deauthorization request started.
*/
isDeauthorizationReqestActive: boolean
isDeauthorizationRequestActive: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, let's also fix the similar typo in the comment above:

* `MAX_UINT64` the deauthorization reqest is pending and an operator have to

let isDeauthorizationRequestActive = true
if (_remainingAuthorizationDecreaseDelay.eq(MAX_UINT64)) {
// If a `remainingAuthorizationDecreaseDelay` is equal `MAX_UINT64` the
// deauthorization reqest is pending and an operator have to call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix a similar typo in this comment

Suggested change
// deauthorization reqest is pending and an operator have to call
// deauthorization request is pending and an operator have to call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants