Adds the suggestion page with file upload to GCP #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld-network/token-dashboard into gcloud-file-upload
…nto gcloud-file-upload
…ld-network/token-dashboard into gcloud-file-upload
…nto gcloud-file-upload
|
Preview uploaded to https://preview.dashboard.test.threshold.network/gcloud-file-upload/index.html. |
r-czajkowski
requested changes
Dec 21, 2022
Comment on lines
+12
to
+17
| return fetch(`https://storage.googleapis.com/${bucket}`, { | ||
| method: "POST", | ||
| body: formData, | ||
| }).then((resp) => { | ||
| return `https://storage.cloud.google.com/${bucket}/${file.name}` | ||
| }) |
There was a problem hiding this comment.
We already use axios as a http client see utils/exchangeApi.ts- we could use it, probably simplify code a little bit. Ofc non-blocking.
| return fetch(`https://storage.googleapis.com/${bucket}`, { | ||
| method: "POST", | ||
| body: formData, | ||
| }).then((resp) => { |
There was a problem hiding this comment.
maybe let's add catch to log any errors and avoid app crashes.
| export const useCapture = (eventName: PosthogEvent) => { | ||
| export const useCapture = ( | ||
| eventName: PosthogEvent, | ||
| overrideConsent = false |
There was a problem hiding this comment.
maybe shouldOverrideConsent?
| suggestion: suggestionText, | ||
| }) | ||
|
|
||
| setIsLoading(false) |
There was a problem hiding this comment.
We probably should set the loading indicator to false once we catch an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds the suggestion page according to designs: https://www.figma.com/file/Tx1lZc7us4SqCeAgbt1hBV/Threshold-Dapp?node-id=4251%3A276860&t=ZmBL64H8ytLsbgVf-0
Per UX discussion we've decided to implement an override for posthog capture events so that suggestions can still be submitted to posthog, even if the user has declined the anonymous analytics tracking.
User files are uploaded to the Google cloud bucket which are permission locked for authorized users only. The link to the file is sent to posthog.