Skip to content

Unify disk label in full & micro vm #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+1 −9
Open

Unify disk label in full & micro vm #4398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bcecd
Unify disk label in full & micro vm
zaelgohary Oct 20, 2025
fa9c894
Remove getDiskLabel fn
zaelgohary Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/playground/src/components/deployment_data_dialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<CopyReadonlyInput
v-for="disk of contract.mounts"
:key="disk.name"
:label="getDiskLabel(contract, disk)"
:label="getDiskLabel(disk)"
:data="Math.ceil(disk.size / (1024 * 1024 * 1024))"
/>
<CopyReadonlyInput
Expand Down Expand Up @@ -307,11 +307,8 @@ function getType(key: string): string {
return "text";
}

function getDiskLabel(contract: DeploymentContract, disk: Disk) {
if (contract.metadata.includes("fullvm") && contract.mounts.indexOf(disk) > 0) {
return "Disk( " + disk.name + " ) GB";
}
return "Disk( " + disk.mountPoint + " ) GB";
function getDiskLabel(disk: any) {
return `Disk ${disk.name}`;
}

function getMetadata(contract: DeploymentContract): { type: string; projectName: string } {
Expand Down Expand Up @@ -355,7 +352,6 @@ import { createCustomToast, ToastType } from "@/utils/custom_toast";
import { GrafanaStatistics } from "@/utils/get_metrics_url";

import { useGrid } from "../stores";
import type { Disk } from "../utils/deploy_vm";
import CopyReadonlyInput from "./copy_readonly_input.vue";
import { HighlightDark, HighlightLight } from "./highlight_themes";

Expand Down