XDR-15964 add detection_sources to incident #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtyzz
requested review from
gbuisson,
yogsototh,
msprunck,
ereteog,
frenchy64,
turbodog99,
wandersoncferreira,
safi,
michaels-den,
samwagg,
marioaquino and
t2sw
as code owners
frenchy64
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://cisco-sbg.atlassian.net/browse/XDR-15686
Closes: https://cisco-sbg.atlassian.net/browse/XDR-15694
Summary: Adds optional
detection_sourcesfield to the Incident object.detection_sourcesdiffers fromsourcein thatsourceis the promoter of the incident, whereasdetection_sourcesis the a set of aggregated sources of detections, such as sightings, that are found in the incident. This is meant be a searchable field on the Incidents List in the UI (see the epic above) and as such must be available via Lucene query.Local generative and testing steps:
lein docand commited resultslein test, which passed