Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ip addresses to agent data source #150

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

joaomper-TE
Copy link
Contributor

@joaomper-TE joaomper-TE commented Dec 5, 2023

As requested within #128 by several users this adds ip addresses to the Agent DataSource:

Changes to Outputs:
  + agent_id     = 123213
  + agent_name   = "Vancouver, Canada"
  + ip_addresses = [
      + "155.313.108.19",
      + "155.313.108.23",
      + "155.313.108.15",
      + "2607:f6f3:3400:96::2:7",
      + "2607:f6f3:3400:96::2:4",
    ]
╷

@joaomper-TE joaomper-TE requested review from pedro-te and a team December 5, 2023 16:04
@brumarqu-te
Copy link
Contributor

i'm not sure but from the referenced issue seems that customer needs the publicIpAddresses.
We need to pull in the IP addresses of agent in Sao-paulo Brazil for example and then allow those IP's on our network firewall

@joaomper-TE
Copy link
Contributor Author

i'm not sure but from the referenced issue seems that customer needs the publicIpAddresses.
We need to pull in the IP addresses of agent in Sao-paulo Brazil for example and then allow those IP's on our network firewall

Yeah, that's a fair question. I asked yesterday in the GH issue to make sure which IP Addresses the user is referring to (will only merge this afterwards)

Copy link
Contributor

@sfreitas-te sfreitas-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the issue number to the log messages

@joaomper-TE joaomper-TE merged commit 3351439 into thousandeyes:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants