fix: resources deleted outside Terraform not re-created #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomper-TE
commented
Nov 30, 2023
| remote, err := readFunc(client, id) | ||
|
|
||
| // Check if the resource no longer exists | ||
| if err != nil && IsNotFoundError(err) { |
There was a problem hiding this comment.
This was the fix.
joaomper-TE
changed the title
joaomper-TE
changed the title
shahid-te
previously approved these changes
Nov 30, 2023
pedro-te
previously approved these changes
Nov 30, 2023
joaomper-TE
commented
Nov 30, 2023
joaomper-TE
force-pushed
the
bug-fix-read-operations
branch
from
598bd1a to
f8f1a2f
Compare
pedro-te
approved these changes
Nov 30, 2023
phpinhei-te
approved these changes
Dec 1, 2023
shahid-te
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112.
Problem was that when attempting to read the resource, we were not handling the 404 properly. Now, we set the ID to null so that terraform understands that the resource no longer exists and tries to recreate it.
Tested locally and now, after the resource is deleted manually in the UI, a
terraform planattempts to re-create it.