Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alert rule severity #147

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

wjwong93
Copy link
Contributor

Hi maintainers, I added support for alert rule severity in the thousandeyes-sdk-go repo recently.
I'd like to update the terraform provider to support that as well.

While I was at it, I also added an example for the thousandeyes_alert_rule resource.

shahid-te
shahid-te previously approved these changes Nov 21, 2023
Copy link

@shahid-te shahid-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing.

@shahid-te shahid-te requested a review from a team November 21, 2023 18:23
@joaomper-TE joaomper-TE merged commit d0005e0 into thousandeyes:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants