-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: labels/groups attachment to tests/agents updates #125
Conversation
@@ -1136,6 +1134,20 @@ var schemas = map[string]*schema.Schema{ | |||
}, | |||
}, | |||
}, | |||
"tests-label": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a schema for tests
right above this one, but I'm not sure what it is being used for, as I don't think it was being used for Labels. Perhaps it can be deleted. I decided to add a new one for the Labels use case, similar to the agents-label
.
At some point we might want to reconsider this "shared" schemas file as we're starting to create many exceptions.
Since this is a breaking change let's first add a mention about the breaking change on the docs and afterwards remove the feature |
Going forward it will no longer be possible to attach a label/group to a test in any test resource. Test resources obtain the labels linked to them via the API automatically (computed fields). Labels are now linked to tests only in the label resource. This diverges from what the ThousandEyes API allows, but is necessary considering how terraform works, as it was previously possible to have a test resource cancel out a label that is being added to it in a label resource, because the test resource wasn't setting it.
Going forward it will no longer be possible to attach a label/group to a test in any test resource. Test resources obtain the labels linked to them via the API automatically (computed fields). Labels are now linked to tests only in the label resource. This diverges from what the ThousandEyes API allows, but is necessary considering how terraform works, as it was previously possible to have a test resource cancel out a label that is being added to it in a label resource, because the test resource wasn't setting the label.
Example:
Furthermore, we should merge this first: thousandeyes/thousandeyes-sdk-go#113
And then update this PR with the new version, as this will be needed in order to support removing all agents/tests from a label. Otherwise that scenario is unsupported by our provider.