Skip to content

Adding certificate id to primary and replica RDS instances #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3-updates
Choose a base branch
from

Conversation

WilliamAvila
Copy link
Collaborator

No description provided.

@WilliamAvila WilliamAvila requested a review from jferris as a code owner July 24, 2024 15:23
variable "ca_cert_id" {
type = string
description = "Certificate authority for RDS database"
default = "rds-ca-rsa2048-g1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a new database is created on RDS, AWS already defines a default certificate authority. The default certificate currently is the same as we're defining here. However, if AWS changes that default certificate to something else, we will accidentally override the recommended default.

I think this is a rare case where we would just manually make the change on the console and not worry about reflecting that change on Terraform. Or, if we want to be able to override the certificate, I would think it would be better to not set a default here (what happens if we set the default to "null"? Would it pick RDS' default?).

What do you think, @OlamideOl1 @WilliamAvila?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised #29 for that, but I didn't have a chance to test what happens when creating a new database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants