Skip to content

Use Ruby 2.7 for development and CI #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 1 commit into from
Aug 24, 2020
Merged

Use Ruby 2.7 for development and CI #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.6.5
2.7.1
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby 2.6.5
ruby 2.7.1
22 changes: 15 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ env:
- DATABASE_ADAPTER=sqlite3
- DATABASE_ADAPTER=postgresql
rvm:
- 2.6.5
- 2.5.7
- 2.4.9
- 2.7.1
- 2.6.6
- 2.5.8
- 2.4.10
gemfile:
- gemfiles/rails_6_0.gemfile
- gemfiles/rails_5_2.gemfile
Expand All @@ -18,14 +19,21 @@ gemfile:
- gemfiles/rails_4_2.gemfile
matrix:
exclude:
- rvm: 2.6.5
- rvm: 2.7.1
gemfile: gemfiles/rails_4_2.gemfile
- rvm: 2.4.9
- rvm: 2.6.6
gemfile: gemfiles/rails_4_2.gemfile
- rvm: 2.4.10
gemfile: gemfiles/rails_6_0.gemfile
cache: bundler
cache:
directories:
- /home/travis/.rvm/gems/ruby-2.7.1
Copy link
Collaborator

@mcmire mcmire Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching was not working properly before. cache: bundler assumes that the install command is not being overridden — if that is the case then Bundler will use vendor/bundle as the installation path. However, since we are overriding install and we are not providing a --path to bundle install, Travis will install gems in a global location, which happens to be under /home/travis/.rvm/gems/ruby-<version>. Here I'm listing out all of the possible cache paths because it will change depending on which Ruby version the build is running under.

- /home/travis/.rvm/gems/ruby-2.6.6
- /home/travis/.rvm/gems/ruby-2.5.8
- /home/travis/.rvm/gems/ruby-2.4.10
# Source: <https://docs.travis-ci.com/user/languages/ruby/#bundler-20>
before_install:
- gem update --system '2.7.8' --no-document
- gem update --system --force --no-document
Copy link
Collaborator

@mcmire mcmire Aug 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the version dependency on this because I was getting deadlock issues when using a version of RubyGems prior to 3.1.0.

- gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
- gem install bundler -v '< 2' --no-document
install: "bundle install --jobs=3 --retry=3"
Expand Down