Aws sdk v2 #1730

danielwanja · 2014-12-17T02:16:22Z

Added s3 storage implementation using the aws-sdk v2.

houndci-bot · 2014-12-17T02:16:30Z

lib/paperclip/storage/s3.rb

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

* Fixed hound notification - removing unused exception variable.

houndci-bot · 2014-12-17T18:16:15Z

lib/paperclip/storage/s3v2.rb

Line is too long. [88/80]

* Using Ruby 1.9 hash syntax * Using double-quoted strings * Space after missing comma * Wrapped lines over 80 characters, unless code was less readable

houndci-bot · 2015-03-10T20:56:16Z

lib/paperclip/storage/s3v2.rb

Assignment Branch Condition size for flush_writes is too high. [31.89/15]

… to investigate difference in environments.

danielwanja · 2015-03-23T20:52:51Z

Do you guys really want me to fix all the houdci notifications. Even the line too long ones? Make code less readable in my view? What else would you like to see fixed for this to be accepted?

booleanbetrayal · 2015-03-24T14:51:34Z

some of those houndci warnings are super aggressive. would be nice to see this changeset get in!

maclover7 · 2015-05-13T00:55:37Z

@tute @jyurek This should probably come in 5.0, right?

tute · 2015-05-13T14:09:15Z

@danielwanja thank you for your work!
@jyurek what do you think about this changeset?

danielwanja · 2015-05-13T15:56:00Z

@tute, my pleasure. Let me know what you thing of this changeset and what would be needed to have this merged.

natesire · 2015-06-01T14:14:32Z

I would like to help with this. I already mocked up a solution for the AWS S3 gem at marcel/aws-s3#108

jyurek · 2015-06-01T14:23:02Z

@nathantechie9 There is no change that needs to happen with the aws-s3 gem. Paperclip has been using the aws-sdk gem for some time now, which is a different gem, but aside from that, the library should not need to change to accommodate us.

jyurek · 2015-06-01T14:23:42Z

@danielwanja I would really appreciate it if you could look at the places Hound says are too complicated and refactor them a bit. Thanks! :)

natesire · 2015-06-01T14:30:05Z

What's the issue with the regions? I'd like to help.

tute · 2015-06-18T04:45:22Z

Is the functionality in this PR comparable to that of #1903?

danielwanja · 2015-06-18T15:14:14Z

Same idea, to use the new aws-sdk v2, different approach. PR #1903
#1903 intermingles V1 and V2
code in the same adapter using checking aws_v1? and calling the
appropriate underlying aws-sdk method. I preferred creating a new adapter
that doesn't mingle both. Being originally from Switzerland I can see
advantages in both approaches. The main goal for me was to be able to use
some of the new features the aws-sdk v2 prodives, notably using the new
kms related headers ("x-amz-server-side-encryption" => "aws:kms",
"x-amz-ssekms-key-id"
=> "alias/mycustom_encryption_key").

On Wed, Jun 17, 2015 at 10:45 PM, Tute Costa [email protected]
wrote:

Is the functionality in this PR comparable to that of #1903
#1903?

—
Reply to this email directly or view it on GitHub
#1730 (comment)
.

tute · 2015-08-24T15:23:07Z

AWS 2 support has been merged: #1903 (comment). Thanks for your work!

danielwanja added 2 commits December 16, 2014 19:08

Added s3 storage implementation based on the aws-sdk v2.

96c6f3a

Specifying gem spec dependencies to use aws-sdk v2 and v1.

8c6bf84

sikachu added the unknown label Dec 17, 2014

houndci-bot reviewed Dec 17, 2014
View reviewed changes

lib/paperclip/storage/s3.rb Outdated

Copy link

houndci-bot Dec 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

* Fixed delete image bug.

c44e97d

* Fixed hound notification - removing unused exception variable.

houndci-bot reviewed Dec 17, 2014
View reviewed changes

lib/paperclip/storage/s3v2.rb Outdated

Copy link

houndci-bot Dec 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [88/80]

Applied many houndci recommendations:

c774546

* Using Ruby 1.9 hash syntax * Using double-quoted strings * Space after missing comma * Wrapped lines over 80 characters, unless code was less readable

houndci-bot reviewed Mar 10, 2015
View reviewed changes

lib/paperclip/storage/s3v2.rb

Copy link

houndci-bot Mar 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for flush_writes is too high. [31.89/15]

danielwanja added 2 commits March 10, 2015 15:14

Pending a test that works locally an not on travis-ci (for now). Need…

0d719ef

… to investigate difference in environments.

Remove pry dependency.

4f4af35

jyurek removed the unknown label Apr 24, 2015

reshleman mentioned this pull request May 12, 2015

Use Updated Version of aws-sdk in Docs [ci skip] #1838

Merged

jyurek mentioned this pull request Jun 1, 2015

Trying to setup paperclip gem locally #1879

Closed

tute force-pushed the master branch from 6d7fecf to ecdd542 Compare June 5, 2015 15:46

tute mentioned this pull request Jun 24, 2015

Don't support aws-sdk version 2.0 #1912

Closed

betesh mentioned this pull request Jun 24, 2015

The long awaited AWS v2 support PR #1903

Closed

Momus mentioned this pull request Jul 27, 2015

Comfy needs downgraded aws-sdk gem to work comfy/comfortable-mexican-sofa#666

Closed

tute closed this Aug 24, 2015

hchood mentioned this pull request Jun 2, 2016

Server-side encryption using AWS' KMS #2221

Closed

Uh oh!

Uh oh!

Aws sdk v2 #1730

Aws sdk v2 #1730

Uh oh!

Conversation

danielwanja commented Dec 17, 2014

Uh oh!

houndci-bot Dec 17, 2014

Choose a reason for hiding this comment

Uh oh!

houndci-bot Dec 17, 2014

Choose a reason for hiding this comment

Uh oh!

houndci-bot Mar 10, 2015

Choose a reason for hiding this comment

Uh oh!

danielwanja commented Mar 23, 2015

Uh oh!

booleanbetrayal commented Mar 24, 2015

Uh oh!

maclover7 commented May 13, 2015

Uh oh!

tute commented May 13, 2015

Uh oh!

danielwanja commented May 13, 2015

Uh oh!

natesire commented Jun 1, 2015

Uh oh!

jyurek commented Jun 1, 2015

Uh oh!

jyurek commented Jun 1, 2015

Uh oh!

natesire commented Jun 1, 2015

Uh oh!

tute commented Jun 18, 2015

Uh oh!

danielwanja commented Jun 18, 2015

Uh oh!

tute commented Aug 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants