Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added brew cask functionality #376

Closed
wants to merge 1 commit into from
Closed

added brew cask functionality #376

wants to merge 1 commit into from

Conversation

autodidacticon
Copy link

Added brew cask.

Added iterm2 as an example. Can remove if desired.

@keith
Copy link
Contributor

keith commented Feb 10, 2015

Just my 2 cents, not really a big deal but I still have issues with cask. Also Homebrew/homebrew-cask#2534

@autodidacticon
Copy link
Author

wrt Homebrew/homebrew-cask#2534, shall I append this to the zshrc?
export HOMEBREW_CASK_OPTS="--appdir=/Applications"

@keith
Copy link
Contributor

keith commented Feb 10, 2015

Yep you can definitely set that. I'm definitely deferring this to others, cask just isn't for me.

@autodidacticon
Copy link
Author

Updated script to append to zshrc to set brew cask opts

@croaky
Copy link
Contributor

croaky commented Feb 14, 2015

The current script doesn't require cask for any packages, does it?

We have https://github.com/thoughtbot/laptop/wiki, which is similar to this pull request, but we don't do a good job linking to it from the "Customize" section of the README.

What if instead of merging this into the codebase, you make any improvements to that wiki page, and then make this pull request just a doc change, adding a link to the wiki from the "Customize" section of the README?

@autodidacticon
Copy link
Author

Put your personal customizations in ~/.laptop.local
Duh.

It seems this is already accounted for in the wiki. Thanks for the feedback. Amended PR as per comments.

@croaky
Copy link
Contributor

croaky commented Feb 15, 2015

@autodidacticon Awesome, thanks. Merged as b153d5e.

@croaky croaky closed this Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants