- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 420
Remove deprecated functionality #801
base: master
Are you sure you want to change the base?
Conversation
         jferris
  
      
      
      commented
      
            jferris
  
      
      
      commented
        Jun 26, 2015 
      
    
  
- Remove old, non-standard driver methods
- Remove non-global config methods
- Remove access to browser instance
- Remove support commands for removed methods
- Remove support for Qt 4
* Remove old, non-standard driver methods * Remove non-global config methods * Remove access to browser instance * Remove support commands for removed methods * Remove support for Qt 4
        
          
                .travis.yml
              
                Outdated
          
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we add qt5-default to this list, we should be able to omit the QMAKE environment variable on line 14.
This backwards-incompatible change brings our behavior in line with Selenium.
| This looks great. I pushed up a few additional changes to the branch. As discussed in #652, we'll now raise an  | 
We don't support Qt 4 anymore.
61a6dcc    to
    a2952d5      
    Compare
  
    | And what about global fonts overriding? I expected it to be removed when update to qt5 https://github.com/thoughtbot/capybara-webkit/blob/master/src/WebPage.cpp#L116 | 
| @amenzhinsky I opened #761 to handle fonts separately from the deprecated functionality. | 
| hey @jferris, Are there any plans about a release 2.0? | 
| 
 I think we will likely release a 2.0 that removes deprecated functionality and is somewhat slimmer, but the main priority is currently to figure out what to do now that QtWebKit is deprecated. |