Add guide for switching templates with the :variant option and add some samples #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This adds a guide and two examples of using Rails' view variant support. Closes thoughtbot#2578 https://guides.rubyonrails.org/layouts_and_rendering.html#the-variants-option
nickcharlton
force-pushed
the
2578-view_variant
branch
from
670cb4c to
237adad
Compare
|
I made a few minor rewording changes, and some style preferences, as I thought I'd be able to get this merged today. But, testing this out just before, I realised that we don't have an obvious way to not be the admin in the demo app to use this functionality. Any ideas on how we could do that? |
nickcharlton
added
the
documentation
|
Thank you. To test it, you can switch to a non-admin user by clicking the "Become" button in each row on the customer list page. |
|
Hah! I totally missed that. I'm glad someone knows the application better than I do after maintaining it for not far off a decade 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a guide on how to switch templates using the variant option.
http://localhost:3000/guides/switching_template_with_the_variant_option.md
Additionally, I have added actual usage examples to the sample application.
I created two examples: one for the template used in the Dashboard and another for non-Dashboard screens. The display changes depending on whether the user is logged in as an Admin or another user.
http://localhost:3000/admin/customers
http://localhost:3000/admin/stats