Open
Conversation
This reverts commit 588b7e4.
dijidiji
approved these changes
Aug 6, 2025
dijidiji
left a comment
There was a problem hiding this comment.
I reviewed the header files and confirmed that the signatures in api.json are generated as expected.
How Has This Been Tested?
I've copied api.json to my local splashkit.io-starlight repo for testing:
- Tested in latest Chrome
- Tested in latest Firefox
- npm run build
- npm run preview
Confirmed the new signatures showed up when including the relevant files:
-
splashkit.py:
def quad_from_line(line_origin, line_end, width):
def draw_bitmap_on_bitmap(destination, bmp, x, y):
def draw_bitmap_on_bitmap_with_options(destination, bmp, x, y, opts):
def set_interface_font_with_string(fnt):
def vector_from_center_sprite_to_point(s, pt):-
SplashKit.cs:
public bool Bitmap.PixelDrawnAtPoint(Point2D pt);
public Vector2D Sprite.VectorFromCenterToPoint(Point2D pt);
Oliver-Quail
approved these changes
Aug 8, 2025
Oliver-Quail
left a comment
There was a problem hiding this comment.
I have reviewed this PR and checked locally as well. I concur with dijidiji that api.json are generated as expected.
I approve this PR
monicavtasmin
approved these changes
Sep 14, 2025
monicavtasmin
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Below are the names of some functions in the Python or C# implementation of the Splashkit library that obviously have issues (ie. repeated words and substrings).
I have fixed the issue by navigating to each header file containing the function declaration and modifying the suffix attribute in the header docs. In most cases, this involved removing a substring from the suffix that was already in the function’s base name and therefore, didn’t need to be added again in the suffix.
Type of change
How Has This Been Tested?
This was tested by running the translator and checking the api.json file to see if the correct function signatures were being generated.
To verify this pull request, you can do the same by going through the commit history and finding the commit named "Generate Files". I have reverted this commit because I don't want it included when this PR finally gets merged but I have left a commit so you don't have to run the translator yourself.
Testing Checklist
Checklist