forked from doubtfire-lms/doubtfire-web
-
Notifications
You must be signed in to change notification settings - Fork 137
feat: tutorial self enrolment task feature #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b0ink
wants to merge
15
commits into
thoth-tech:8.0.x
Choose a base branch
from
b0ink:feat/tutorial-self-enrolment
base: 8.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9053c80
feat: task definition toggle for tutorial enrolment feature
b0ink 2b99b06
feat: add task card to prompt tutorial enrolment
b0ink 2cbb3d9
fix: typo
b0ink c02d8a1
chore: improve wording
b0ink 7f77750
feat: add tutorial enrolment modal
b0ink c9a8ae9
feat: check for existing tutorial enrolment
b0ink 90693f1
fix: typo
b0ink 344fac2
feat: enrol student into tutorial
b0ink 9a0feef
feat: disable enrolment button if no tutorial selected
b0ink 15ba574
feat: add new schema properties
b0ink 6f12dcf
Merge remote-tracking branch 'thoth/8.0.x' into feat/tutorial-self-en…
b0ink 83d5c07
refactor: map stream abbreviation to tutorial stream object
b0ink 95815d0
chore: replace debug stream with live data
b0ink 4a92dc0
fix: remove debug
b0ink dcef998
fix: remove unused var
b0ink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ export class TaskDefinitionTutorialEnrolmentComponent implements OnInit { | |
|
|
||
| public _selectedTutorialStreams: TutorialStream[] = []; | ||
|
|
||
| tutoralStreamControl = new FormControl<TutorialStream | null>(null, Validators.required); | ||
| tutoralStreamControl = new FormControl<TutorialStream | null>(null, Validators.required); | ||
|
|
||
| public ngOnInit(): void { | ||
| const tutorialStreams = this.taskDefinition.unit.tutorialStreamsCache.currentValues; | ||
|
|
@@ -27,6 +27,17 @@ export class TaskDefinitionTutorialEnrolmentComponent implements OnInit { | |
| console.log(stream); | ||
| this._tutorialStreams.push(stream); | ||
| } | ||
|
|
||
| console.log(this.taskDefinition.tutorialSelfEnrolmentStream); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This log should probably be removed. |
||
| this.tutoralStreamControl.setValue(this.taskDefinition.tutorialSelfEnrolmentStream); | ||
| } | ||
|
|
||
| public onSelectStream(): void { | ||
| const selectedStream = this.tutoralStreamControl.value; | ||
| if (selectedStream) { | ||
| console.log(selectedStream); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This log should probably be removed |
||
| this.taskDefinition.tutorialSelfEnrolmentStream = selectedStream; | ||
| } | ||
| } | ||
|
|
||
| constructor( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log should probably be removed.