fix(task): resolve feedback notification issue

.gitattributes

@@ -0,0 +1,2 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto eol=lf

.gitignore

@@ -36,5 +36,4 @@ student-work/
 .idea/
 .byebug_history
 coverage/
-.vscode
 _history

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "files.eol": "\n"
+}

Gemfile.lock

@@ -168,6 +168,7 @@ GEM
     faraday-net_http (3.1.0)
       net-http
     ffi (1.17.0-aarch64-linux-gnu)
+    ffi (1.17.0-x86_64-linux-gnu)
     fugit (1.11.0)
       et-orbi (~> 1, >= 1.2.11)
       raabro (~> 1.4)
@@ -265,6 +266,8 @@ GEM
     nio4r (2.7.3)
     nokogiri (1.16.5-aarch64-linux)
       racc (~> 1.4)
+    nokogiri (1.16.5-x86_64-linux)
+      racc (~> 1.4)
     observer (0.1.2)
     orm_adapter (0.5.0)
     parallel (1.24.0)
@@ -490,6 +493,7 @@ GEM
 
 PLATFORMS
   aarch64-linux
+  x86_64-linux
 
 DEPENDENCIES
   better_errors

app/api/users_api.rb

@@ -67,8 +67,8 @@ class UsersApi < Grape::API
     change_self = (params[:id] == current_user.id)
 
     params[:receive_portfolio_notifications] = true if params.key?(:receive_portfolio_notifications) && params[:receive_portfolio_notifications].nil?
-    params[:receive_portfolio_notifications] = true if params.key?(:receive_feedback_notifications) && params[:receive_feedback_notifications].nil?
-    params[:receive_portfolio_notifications] = true if params.key?(:receive_task_notifications) && params[:receive_task_notifications].nil?
+    params[:receive_feedback_notifications] = true if params.key?(:receive_feedback_notifications) && params[:receive_feedback_notifications].nil?
+    params[:receive_task_notifications] = true if params.key?(:receive_task_notifications) && params[:receive_task_notifications].nil?
 
     # can only modify if current_user.id is same as :id provided
     # (i.e., user wants to update their own data) or if update_user token

app/models/task.rb

@@ -132,6 +132,7 @@ def specific_permission_hash(role, perm_hash, _other)
   delegate :update_task_stats, to: :project
 
   after_update :update_task_stats, if: :saved_change_to_task_status_id? # TODO: consider moving to async task
+  after_update :send_feedback_notification, if: :saved_change_to_task_status_id?
 
   validates :task_definition_id, uniqueness: { scope: :project,
                                                message: 'must be unique within the project' }
@@ -1362,6 +1363,20 @@ def read_file_from_done(idx)
     nil
   end
 
+  def send_feedback_notification
+    return unless task_status.in?([TaskStatus.redo, TaskStatus.fail, TaskStatus.fix_and_resubmit, TaskStatus.feedback_exceeded, TaskStatus.discuss, TaskStatus.demonstrate, TaskStatus.complete])
+    return unless project.student.receive_feedback_notifications
+    return unless unit.send_notifications
+
+    begin
+      logger.info "Checking feedback email for project #{project.id}"
+      logger.info "Emailing feedback notification to #{project.student.name}"
+      PortfolioEvidenceMailer.task_feedback_ready(project, [self]).deliver
+    rescue => e
+      logger.error "Failed to send feedback notification email. Error: #{e.message}"
+    end
+  end
+
   private
 
   def delete_associated_files

config/environments/development.rb

@@ -53,14 +53,21 @@
   # Store uploaded files on the local file system (see config/storage.yml for options).
   # config.active_storage.service = :local
 
-  # Don't care if the mailer can't send.
-  config.action_mailer.raise_delivery_errors = false
-
-  config.action_mailer.perform_caching = false
-
-  # Tell Action Mailer not to deliver emails to the real world.
-  # Write them to file instead (under doubtfire-api/tmp/mails)
-  config.action_mailer.delivery_method = :file
+ # Don't care if the mailer can't send.
+ config.action_mailer.raise_delivery_errors = true
+
+ config.action_mailer.perform_caching = false
+
+ # Tell Action Mailer not to deliver emails to the real world.
+ # Write them to file instead (under doubtfire-api/tmp/mails)
+ config.action_mailer.delivery_method = :file
+ config.action_mailer.file_settings = { 
+   :location => File.join(Rails.root, 'tmp', 'mails')
+ }
+
+ # Add more verbose logging for ActionMailer
+ config.action_mailer.logger = Logger.new(STDOUT)
+ config.action_mailer.logger.level = Logger::DEBUG
 
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log