docs: add projects/index migration investigation and plan#165
docs: add projects/index migration investigation and plan#165JeffySam wants to merge 22 commits intothoth-tech:mainfrom
Conversation
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hi @JeffySam,
I checked out your changes locally. The content of the two documents seems a little trivial, but I think there's probably a place for this kind of process or action log. I don't think that place is in the root Markdown directory of src/content/docs; currently the only way to view your contribution is to directly navigate to /projects_index_migration_plan/, try this link to see what I'm talking about - or similar for your investigation document.
- Please try to find a new location for these two files, perhaps under
src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration.
In addition, the table on the rendered page looks kind of bad:
Notice the right-hand column extending all the way to the right of the container. This isn't your fault, but I think it should be fixed:
- You can find the custom CSS at
src/content/styles/custom.css. Please add the following property and value inside the CSS rule for.sl-markdown-content tableselector:max-width: max-content;
|
hi @SteveDala Thanks for the review!
|
SteveDala
left a comment
There was a problem hiding this comment.
There are still a couple of nits. See below
| verify that subscriptions are cleaned up correctly, and confirm that behaviour | ||
| matches the legacy implementation. | ||
|
|
||
| ## Child State Verification Matrix |
There was a problem hiding this comment.
The table that was previously here no longer exists. Was this intentional? If so, please remove this heading.
...roducts/OnTrack/Documentation/Front End Migration/Migration/PROJECTS_INDEX_MIGRATION_PLAN.md
Show resolved
Hide resolved
|
@SteveDala Thanks for the follow-up!
|
There was a problem hiding this comment.
Approved. @BrianDangDev please proceed with an approving review to merge.
|
Hi @SteveDala , quick heads-up — I removed the Units module docs from this PR as they’re meant for a separate documentation PR. The originally approved content is unchanged. Could you please re-approve when you get a moment? Thanks! |
|
As the content is not substantially different than my previous approval, the approval stands. |
|
Hi @JeffySam , a check failed, please have a look at the highlighted text and follow the instruction to fix the format issue, should be a simple fix |
|
@BrianDangDev hey brian i have fixed the issue, hopefully it'll pass all the tests now |
|
Prettier error still show up @JeffySam |
|
@JeffySam please sync your branch with main then i will run the checks again |
|
Hi @JeffySam, in your local development environment, please execute Checking formatting...
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/PROJECTS_INDEX_MIGRATION_INVESTIGATION.md
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/PROJECTS_INDEX_MIGRATION_PLAN.md
[warn] Code style issues found in 2 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1. |
|
@JeffySam please make sure your changes are based on the latest upstream changes to main. |
|
@SteveDala i did everything and its still failing the tests |
|
@JeffySam, I have recently forked the main branch of this repository, opened it in the VSCode development container, and ran all the checks that the GitHub CI pipeline runs. All came back successful, including Prettier. In addition, your attempts to fix the linting issues means your pull request is now extremely big compared to the actual scope of the change requested. I believe you should try again with a fresh fork of the main branch. In your terminal, run this (make a new copy of the repo): git clone https://github.com/thoth-tech/ThothTech-Documentation-Website.git
cd ThothTech-Documentation-Website
git remote rename origin upstream
git remote add origin https://github.com/JeffySam/ThothTech-Documentation-Website.gitPlace the Markdown files for the original pull request in the folder locally (while on the main branch), then run... git add .
git commit -m "docs: add projects/index migration investigation and plan"
git push origin --forceThis should tidy up your pull request and provided the Markdown files are formatted and pass the Vale checks, we should be good to merge them. |
|
Hey @SteveDala I did all this already and even in my terminal it’ says the same.. |
|
@JeffySam Again, I suggest you clone a new copy of the repo and follow the steps I outlined above. I'm not sure how your original repo ended up the way it is now and there's only so much I can do to support your errors from GitHub. One clue that might be worth checking is that I noticed in the image above you are currently on the branch |
|
@SteveDala I was on the docs/units-module-migration-clean branch when taking that screenshot. For these two pull requests, I worked on separate documentation branches rather than directly on main, which is why that branch was showing. I’ll go ahead and clone a fresh copy of the repository and follow the steps you outlined from scratch to rule out any local issues on my end. I’ll update you once I’ve re-tested everything on a clean setup. |


Description
This PR adds documentation for the migration of the
projects/indexparent state from AngularJS to Angular.Included documents
Projects Index Migration Investigation
Projects Index Migration Plan
Scope
Purpose
To provide clear technical context and a structured, low-risk path
to finalising the
projects/indexparent state migration.