Experimental --scoring flag for scorecards metrics #1155
Conversation
sesheta
added
the
size/L
mayaCostantini
force-pushed
the
experimental-metrics
branch
2 times, most recently
from
407d08a to
4c2f5f1
Compare
mayaCostantini
force-pushed
the
experimental-metrics
branch
from
4c2f5f1 to
4c55464
Compare
|
Related to #1148 |
|
@harshad16 @KPostOffice ready for review 👍 |
|
/lgtm |
thamos/cli.py
Outdated
| if "Project " in message: | ||
| message = message.replace("Project ", "projects ") | ||
|
|
||
| if " is " in message: | ||
| message = message.replace(" is ", " are ") | ||
|
|
||
| if " does " in message: | ||
| message = message.replace(" does ", " do ") | ||
|
|
||
| if " has " in message: | ||
| message = message.replace(" has ", " have ") | ||
|
|
||
| if " runs " in message: | ||
| message = message.replace(" runs ", " run ") | ||
|
|
||
| if " requires " in message: | ||
| message = message.replace(" requires ", " require ") | ||
|
|
||
| if " uses " in message: | ||
| message = message.replace(" uses ", " use ") | ||
|
|
||
| if " follows " in message: | ||
| message = message.replace(" follows ", " follow ") | ||
|
|
||
| if " signs " in message: | ||
| message = message.replace(" signs ", " sign ") | ||
|
|
||
| if " NOT " in message: | ||
| message = message.replace(" NOT ", " not ") |
There was a problem hiding this comment.
can share what functionality is this for, it this to fix the grammer of the sentence ?
also how about using a dict with these words and replacing them with a function looping over dict and message? is there any significant value to use if conditions here?
There was a problem hiding this comment.
I implemented this (dirty) workaround to correct the message grammar while we wait for more prescriptions to be generated using tags. When most prescriptions will contain metadata about the type of Scorecard they are based on in their tag, then we could remove this and leave only the logic that uses a dictionary I also implemented in this PR. Does this sound like a good temporary solution to you?
There was a problem hiding this comment.
ack, i think this clears my thoughts.
As we would like to have these grammar change till we wait on prescriptions to be generated using tags.
how about, make the grammer fix words into a dict solution, so that if we found something else needed to be correct just would need to be added to a dict instead of a new if statement.
just for easy of updates.
Example:
def fix_message(message, replace_words):
for k,v in replace_words.items():
message = message.replace(k,v)
return message
replace_words = {"Projects":"project", "is":"are",...}
msg= fix_message(mesage,replace_wrods)
Wdyt? i dont feel strongly about this, if you say it's temp, we can go with it.
Its just that we have too many if statement doing the same task.
There was a problem hiding this comment.
Yes, that sounds better to me, I will make this change 👍
|
@harshad16 ready for review 👍 |
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goern The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
|
@mayaCostantini could you do a tiny asciinema demo for the new output? |
|
@goern Sure |
Related Issues and Dependencies
Related to thoth-station/core#434 and #1149
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Users can pass the
--scoringflag to thethamos advisecommand to get a summary of metrics about the quality of their dependencies as described by Security Scorecards. The next step would be to aggregate metrics about packages present in Thoth's knowledge base to be able to compare the user's dependencies quality to the average dependency quality based on those metrics.