Skip to content

Add bang plot functions #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thorek1
Copy link
Owner

@thorek1 thorek1 commented Jun 4, 2025

Summary

  • allow overlaying of IRF and other plots using new bang functions
  • reexport the new bang functions from MacroModelling
  • combine plot panels by sorted titles so overlay order is consistent

Testing

  • julia --project -e 'using Pkg; Pkg.test()' (fails: julia: command not found)

https://chatgpt.com/codex/tasks/task_e_684077b171e0832f950876e399b02eba

@thorek1 thorek1 added the codex label Jun 4, 2025 — with ChatGPT Connector
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 142 lines in your changes missing coverage. Please review.

Project coverage is 41.65%. Comparing base (67a68a2) to head (2fdfdc0).

Files with missing lines Patch % Lines
src/plotting.jl 0.00% 142 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (67a68a2) and HEAD (2fdfdc0). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (67a68a2) HEAD (2fdfdc0)
19 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #110       +/-   ##
===========================================
- Coverage   86.09%   41.65%   -44.45%     
===========================================
  Files          18       18               
  Lines       10172    10322      +150     
===========================================
- Hits         8758     4300     -4458     
- Misses       1414     6022     +4608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Jun 5, 2025

Benchmark Results

main 2fdfdc0... main / 2fdfdc0...
FS2000/NSSS 12.3 ± 1.1 μs 12.7 ± 1 μs 0.968 ± 0.12
FS2000/covariance 0.18 ± 0.0052 ms 0.183 ± 0.0039 ms 0.985 ± 0.035
FS2000/irf 1.1 ± 0.055 ms 1.1 ± 0.063 ms 1 ± 0.076
FS2000/jacobian 0.0468 ± 0.0013 ms 0.0481 ± 0.0013 ms 0.972 ± 0.038
FS2000/lyapunov/bartels_stewart 0.0961 ± 0.001 ms 0.0983 ± 0.0017 ms 0.977 ± 0.02
FS2000/lyapunov/bicgstab 30.4 ± 13 μs 30.8 ± 13 μs 0.986 ± 0.6
FS2000/lyapunov/doubling 0.0513 ± 0.013 ms 0.0512 ± 0.014 ms 1 ± 0.37
FS2000/lyapunov/gmres 25.9 ± 1.4 μs 26.6 ± 2.9 μs 0.973 ± 0.12
FS2000/qme/doubling 0.122 ± 0.0022 ms 0.124 ± 0.0021 ms 0.99 ± 0.024
FS2000/qme/schur 0.0816 ± 0.016 ms 0.0788 ± 0.015 ms 1.04 ± 0.29
NAWM_EAUS_2008/NSSS 6.29 ± 0.15 ms 0.142 ± 0.0056 s 0.0444 ± 0.0021
NAWM_EAUS_2008/covariance 0.032 ± 0.0035 s 0.168 ± 0.0009 s 0.19 ± 0.021
NAWM_EAUS_2008/irf 0.0323 ± 0.0011 s 0.169 ± 0.002 s 0.191 ± 0.007
NAWM_EAUS_2008/jacobian 0.944 ± 0.014 ms 0.975 ± 0.012 ms 0.969 ± 0.019
NAWM_EAUS_2008/lyapunov/bartels_stewart 28.8 ± 1.9 ms 28.6 ± 1.2 ms 1.01 ± 0.078
NAWM_EAUS_2008/lyapunov/bicgstab 0.259 ± 0.0033 s 0.219 ± 0.0024 s 1.19 ± 0.02
NAWM_EAUS_2008/lyapunov/doubling 17.9 ± 0.61 ms 18 ± 0.52 ms 0.997 ± 0.045
NAWM_EAUS_2008/lyapunov/gmres 0.153 ± 0.0074 s 0.149 ± 0.0041 s 1.02 ± 0.057
NAWM_EAUS_2008/qme/doubling 23.1 ± 2.3 ms 25.9 ± 2.3 ms 0.891 ± 0.12
NAWM_EAUS_2008/qme/schur 17.1 ± 0.53 ms 17.2 ± 0.51 ms 0.997 ± 0.043
Smets_Wouters_2007/NSSS 0.172 ± 0.0065 ms 0.176 ± 0.0042 ms 0.979 ± 0.044
Smets_Wouters_2007/covariance 1.97 ± 0.12 ms 1.97 ± 0.11 ms 0.997 ± 0.082
Smets_Wouters_2007/irf 6.1 ± 0.28 ms 6.04 ± 0.28 ms 1.01 ± 0.066
Smets_Wouters_2007/jacobian 0.28 ± 0.0034 ms 0.294 ± 0.0023 ms 0.955 ± 0.014
Smets_Wouters_2007/lyapunov/bartels_stewart 1.45 ± 0.015 ms 1.47 ± 0.014 ms 0.993 ± 0.014
Smets_Wouters_2007/lyapunov/bicgstab 6.08 ± 0.13 ms 6.18 ± 0.15 ms 0.984 ± 0.032
Smets_Wouters_2007/lyapunov/doubling 0.965 ± 0.016 ms 0.969 ± 0.017 ms 0.996 ± 0.024
Smets_Wouters_2007/lyapunov/gmres 6.93 ± 0.44 ms 7.01 ± 0.37 ms 0.99 ± 0.082
Smets_Wouters_2007/qme/doubling 1.73 ± 0.02 ms 1.76 ± 0.031 ms 0.981 ± 0.021
Smets_Wouters_2007/qme/schur 1.49 ± 0.034 ms 1.22 ± 0.034 ms 1.23 ± 0.044
time_to_load 10.6 ± 0.13 s 10.6 ± 0.062 s 1 ± 0.013
main 2fdfdc0... main / 2fdfdc0...
FS2000/NSSS 0.349 k allocs: 16.8 kB 0.35 k allocs: 16.8 kB 0.997
FS2000/covariance 1.17 k allocs: 0.13 MB 1.17 k allocs: 0.13 MB 1
FS2000/irf 7.6 k allocs: 0.355 MB 7.6 k allocs: 0.356 MB 1
FS2000/jacobian 0.134 k allocs: 4.86 kB 0.134 k allocs: 4.86 kB 1
FS2000/lyapunov/bartels_stewart 0.076 k allocs: 0.0657 MB 0.076 k allocs: 0.0657 MB 1
FS2000/lyapunov/bicgstab 0.089 k allocs: 0.0378 MB 0.089 k allocs: 0.0378 MB 1
FS2000/lyapunov/doubling 0.063 k allocs: 0.0393 MB 0.063 k allocs: 0.0393 MB 1
FS2000/lyapunov/gmres 0.147 k allocs: 0.0816 MB 0.147 k allocs: 0.0816 MB 1
FS2000/qme/doubling 0.199 k allocs: 0.0434 MB 0.199 k allocs: 0.0434 MB 1
FS2000/qme/schur 0.263 k allocs: 0.0848 MB 0.263 k allocs: 0.0848 MB 1
NAWM_EAUS_2008/NSSS 2 k allocs: 4.71 MB 19.7 k allocs: 0.0973 GB 0.0472
NAWM_EAUS_2008/covariance 6.77 k allocs: 18 MB 24.5 k allocs: 0.11 GB 0.16
NAWM_EAUS_2008/irf 0.112 M allocs: 19.9 MB 0.13 M allocs: 0.112 GB 0.173
NAWM_EAUS_2008/jacobian 2.23 k allocs: 0.0683 MB 2.23 k allocs: 0.0683 MB 1
NAWM_EAUS_2008/lyapunov/bartels_stewart 0.079 k allocs: 4.92 MB 0.079 k allocs: 4.92 MB 1
NAWM_EAUS_2008/lyapunov/bicgstab 0.092 k allocs: 5.66 MB 0.092 k allocs: 5.66 MB 1
NAWM_EAUS_2008/lyapunov/doubling 0.07 k allocs: 6.87 MB 0.07 k allocs: 6.87 MB 1
NAWM_EAUS_2008/lyapunov/gmres 0.392 k allocs: 0.0412 GB 0.395 k allocs: 0.0416 GB 0.991
NAWM_EAUS_2008/qme/doubling 0.305 k allocs: 6.29 MB 0.305 k allocs: 6.29 MB 1
NAWM_EAUS_2008/qme/schur 0.41 k allocs: 7.4 MB 0.41 k allocs: 7.4 MB 1
Smets_Wouters_2007/NSSS 1.33 k allocs: 0.146 MB 1.28 k allocs: 0.145 MB 1
Smets_Wouters_2007/covariance 3.59 k allocs: 1.37 MB 3.54 k allocs: 1.37 MB 1
Smets_Wouters_2007/irf 0.0366 M allocs: 2.4 MB 0.0366 M allocs: 2.4 MB 1
Smets_Wouters_2007/jacobian 0.491 k allocs: 18.3 kB 0.491 k allocs: 18.3 kB 1
Smets_Wouters_2007/lyapunov/bartels_stewart 0.078 k allocs: 0.44 MB 0.078 k allocs: 0.44 MB 1
Smets_Wouters_2007/lyapunov/bicgstab 0.091 k allocs: 0.469 MB 0.091 k allocs: 0.469 MB 1
Smets_Wouters_2007/lyapunov/doubling 0.069 k allocs: 0.568 MB 0.069 k allocs: 0.568 MB 1
Smets_Wouters_2007/lyapunov/gmres 0.303 k allocs: 2.66 MB 0.303 k allocs: 2.66 MB 1
Smets_Wouters_2007/qme/doubling 0.298 k allocs: 0.624 MB 0.298 k allocs: 0.624 MB 1
Smets_Wouters_2007/qme/schur 0.398 k allocs: 0.757 MB 0.398 k allocs: 0.757 MB 1
time_to_load 0.153 k allocs: 10.7 kB 0.153 k allocs: 10.7 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants